From owner-cvs-all Fri Apr 12 13:27:27 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 664) id E3F5D37B416; Fri, 12 Apr 2002 13:27:21 -0700 (PDT) Date: Fri, 12 Apr 2002 13:27:21 -0700 From: David O'Brien To: Maxim Sobolev Cc: Gerald Pfeifer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/emulators/wine Makefile distinfo pkg-plist Message-ID: <20020412132721.A66608@hub.freebsd.org> Reply-To: obrien@freebsd.org References: <200204121950.g3CJo0O21945@vega.vega.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200204121950.g3CJo0O21945@vega.vega.com>; from sobomax@FreeBSD.org on Fri, Apr 12, 2002 at 10:49:59PM +0300 X-Operating-System: FreeBSD 4.5-STABLE Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Apr 12, 2002 at 10:49:59PM +0300, Maxim Sobolev wrote: > > > Reviewed by: ??? > > > Approved by: ??? > > > > I have been the maintainer of this port since 2000/05/18. > > > > And while David O'Brien (my mentor here) kindly has been and will be > > reviewing my patches to all other parts of FreeBSD, do I really need > > to have my changes to this port reviewed/approved by others now, after > > having submitted/reviewed/approved more than two dozen changes as > > maintainer of this port??? > > Yes, you need. This is normal part of your "mentored" period. You > mentor should have told you that. Uh... Why does he need it for a port he has maintained for that long? When I have committed his Wine patches (or any approved by him), I did not look at them at all. I just: patch < foo make cvs ci I agree with your statement about things outside of ports/emulators/wine. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message