From owner-svn-src-all@freebsd.org Fri Feb 15 19:00:52 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05F5914E52DA for ; Fri, 15 Feb 2019 19:00:52 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7ADB277F72 for ; Fri, 15 Feb 2019 19:00:51 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-ed1-f65.google.com with SMTP id b17so8856505eds.2 for ; Fri, 15 Feb 2019 11:00:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRNLzqLNjVsZqCRTMNCUV1x68G46TjZI1q/GElSf/OY=; b=PnSc/+qpARUsRuRts7euY3pGj+pUE+ym+2gNqoOaLSwA7zbjdGq0sK3oE99l5eiPO9 giJTpeMr6nXbg2Gi9muEr6bcjWJwchNYVzRQuFJzin9NiHKh1ZhqT0UFvtqXSQ5G7Jc2 BRhEcaJ4fdsXtemK5fW+qwhmMRaFVauP0fji08YtWK+3pomFUOSBm7F7PQoq+vNubg6t ym+r3TvAx+1VkdH8lMjX0h8xIUzwqHcGYAiLTN3o5Azchmabpl1e/93dLx1zSljnFaI2 3RJeylMWbrcp8SonZRgUPTebBOMSYGv2NHRNs3xPfJUwiCNvelL/OOLSIyA1UsvtaP56 2sAA== X-Gm-Message-State: AHQUAuZcZeuwNhqEFGy6LbeAg0ftW/GiXKXU6iJU9pcZ00IPyEiCbO4d r1auEbKSwO/SJYD8EOMtUVcSNGwI X-Google-Smtp-Source: AHgI3Ia1zjajLwqmAGCaFadlx0DNpA3FGV914v68KvO0y+GwV6fuqsK+x8JjMe+Rdci+XhsxeuNvqw== X-Received: by 2002:a17:906:31c7:: with SMTP id f7mr7455454ejf.91.1550256875468; Fri, 15 Feb 2019 10:54:35 -0800 (PST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id m3sm1394350eja.11.2019.02.15.10.54.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 10:54:34 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id b11so10981328wmj.1 for ; Fri, 15 Feb 2019 10:54:34 -0800 (PST) X-Received: by 2002:a1c:ce0e:: with SMTP id e14mr8047533wmg.53.1550256874182; Fri, 15 Feb 2019 10:54:34 -0800 (PST) MIME-Version: 1.0 References: <201902141822.x1EIMjPk087175@pdx.rh.CN85.dnsmgr.net> <9b32ae9a-3cca-3529-fb65-96026a14dbbd@FreeBSD.org> In-Reply-To: <9b32ae9a-3cca-3529-fb65-96026a14dbbd@FreeBSD.org> From: Eric Joyner Date: Fri, 15 Feb 2019 10:54:23 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r344132 - head/sys/dev/ixl To: John Baldwin Cc: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 7ADB277F72 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 19:00:52 -0000 I thought the same thing that John wrote -- I only need re@ approval for MFC's during the release process. I know it's unusually fast to have an MFC period of 1 day, but this change could fix a kernel panic when r344062 is MFC'd and doesn't result in a functional change to the driver, so I didn't think there was a reason for it to sit longer. - Eric On Thu, Feb 14, 2019 at 11:28 AM John Baldwin wrote: > On 2/14/19 10:22 AM, Rodney W. Grimes wrote: > >> Author: erj > >> Date: Thu Feb 14 18:02:37 2019 > >> New Revision: 344132 > >> URL: https://svnweb.freebsd.org/changeset/base/344132 > >> > >> Log: > >> ixl: Fix panic caused by bug exposed by r344062 > >> > >> Don't use a struct if_irq for IFLIB_INTR_IOV type interrupts since > that results > >> in get_core_offset() being called on them, and get_core_offset() > doesn't > >> handle IFLIB_INTR_IOV type interrupts, which results in an assert() > being triggered > >> in iflib_irq_set_affinity(). > >> > >> PR: 235730 > >> Reported by: Jeffrey Pieper > >> MFC after: 1 day > > > > Normally you would request an RE@ approval for a fast track to stable, > > consider this message such an approval. > > That does not match our historical practice over the past 20 years. If we > want to change that practice, that's a topic we can debate, but re@ has > only required oversight on MFC's during slushes/freezes with the additional > caveat of perhaps watching out for ABI breakage at any time (and requiring > approvals for a known ABI breakage on a branch). > > -- > John Baldwin > > > >