From owner-freebsd-current@FreeBSD.ORG Sun Jun 28 13:04:05 2009 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A593E1065670; Sun, 28 Jun 2009 13:04:05 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7D2478FC19; Sun, 28 Jun 2009 13:04:05 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id D0D3A46B65; Sun, 28 Jun 2009 09:04:04 -0400 (EDT) Date: Sun, 28 Jun 2009 14:04:04 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Thomas Backman In-Reply-To: <24BDCB76-0304-443A-96A9-71C5E537FF37@exscape.org> Message-ID: References: <200906241741.n5OHfTaw022417@svn.freebsd.org> <4A43893F.5070100@andric.com> <24BDCB76-0304-443A-96A9-71C5E537FF37@exscape.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Jack F Vogel , Dimitry Andric , current@FreeBSD.org Subject: Re: VMWare if_em breakage (was: Re: svn commit: r194865 - in head/sys: dev/e1000 modules/igb) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2009 13:04:05 -0000 On Sun, 28 Jun 2009, Thomas Backman wrote: > On Jun 25, 2009, at 04:27 PM, Dimitry Andric wrote: > >> On 2009-06-25 16:08, Robert Watson wrote: >>> Since this change (and the two followups), I'm no longer able to use if_em >>> reliable in VMWare Fusion. >> >> Same here, for VMware Workstation. The interface just stops working after >> a bit of traffic. > > Not sure it's needed, but here's another "me too", also using Fusion. At > first I thought it had frozen, but locally, in the VM window, everything > worked fine. (I always interact with VMs via SSH to get copy/paste, better > fonts etc). Also worth mentioning is that vmware-vmx ate 100% real CPU the > entire time, despite the VM CPU (top in FreeBSD) showed 100% *idle*. Jack suggested this patch for me to test, and it seems to work here, so hopefully he doesn't mind my sharing it until it before it gets into SVN. It seems to entirely prevent the problem from occuring here. Robert N M Watson Computer Laboratory University of Cambridge Index: if_em.c =================================================================== --- if_em.c (revision 195108) +++ if_em.c (working copy) @@ -4446,7 +4446,7 @@ struct mbuf *mp; u8 status, accept_frame = 0, eop = 0; u16 len, desc_len, prev_len_adj; - u32 i, rx_sent = 0; + int i, rx_sent = 0; struct e1000_rx_desc *current_desc; EM_RX_LOCK(adapter);