From owner-svn-src-all@FreeBSD.ORG Thu Feb 16 17:48:00 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 150CD106564A; Thu, 16 Feb 2012 17:48:00 +0000 (UTC) (envelope-from ken@kdm.org) Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81]) by mx1.freebsd.org (Postfix) with ESMTP id 6C39C8FC14; Thu, 16 Feb 2012 17:47:59 +0000 (UTC) Received: from nargothrond.kdm.org (localhost [127.0.0.1]) by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id q1GHlw1D070466; Thu, 16 Feb 2012 10:47:58 -0700 (MST) (envelope-from ken@nargothrond.kdm.org) Received: (from ken@localhost) by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id q1GHlw3T070465; Thu, 16 Feb 2012 10:47:58 -0700 (MST) (envelope-from ken) Date: Thu, 16 Feb 2012 10:47:58 -0700 From: "Kenneth D. Merry" To: Andriy Gapon Message-ID: <20120216174758.GA64180@nargothrond.kdm.org> References: <201202160511.q1G5BZNk099785@svn.freebsd.org> <20120216181210.K1423@besplex.bde.org> <4F3CC40D.4000307@freebsd.org> <4F3CC5C4.7020501@FreeBSD.org> <4F3CC8A5.3030107@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3CC8A5.3030107@FreeBSD.org> User-Agent: Mutt/1.4.2i Cc: src-committers@FreeBSD.org, Eitan Adler , svn-src-all@FreeBSD.org, Bruce Evans , svn-src-head@FreeBSD.org, Julian Elischer Subject: Re: svn commit: r231814 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2012 17:48:00 -0000 On Thu, Feb 16, 2012 at 11:13:09 +0200, Andriy Gapon wrote: > on 16/02/2012 11:00 Andriy Gapon said the following: > > on 16/02/2012 10:53 Julian Elischer said the following: > >> Bruce, this is a good example of a legitimate gripe going un-noticed because > >> you didn't shout loud enough at the right time, at the right people. > >> It's been about 20 years since we started working on this but I've finally > >> come to the point of saying that we need you to do more when you see problems. > >> object officially if you think things should be backed out! > >> > >> your reasons here seem sound, so it's hard to see why you haven't been more > >> public about it. > > > > Just for the record: Bruce and I voiced opinions against the commit when it went > > in after a rather short notice for such an important thing. The opinions > > can be found in the archives of these lists. > > To be more precise: s/opinions against/concerns about behavior in the edge cases/. > > For me personally the immediate benefits in the common situations outweighed the > problems in the edge cases, although I still believe that we can get the former > without sacrifices in the latter. I will happily back the message buffer locking changes out if you and Bruce agree that that is the best thing to do. I can also review any proposed fixes to the message buffer locking code, but I really don't have the bandwidth right now to come up with the "real" solution. Sorry I didn't get around to dealing with it, I should have said something months ago. Now that you know a fix won't be coming from me, you two can let me know whether you'd like the changes backed out, or you are certainly free to commit a solution yourselves. Ken -- Kenneth Merry ken@FreeBSD.org