Date: Fri, 15 Jan 2016 09:19:40 +0100 From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <jean-sebastien.pedron@dumbbell.fr> To: Nikola Pajkovsky <n.pajkovsky@gmail.com> Cc: freebsd-x11@freebsd.org Subject: Re: build-able drm-i915-update-38 Message-ID: <5698AB9C.9070005@dumbbell.fr> In-Reply-To: <864mehduk6.fsf@freebsd.lan> References: <87oacpdguk.fsf@gooddata.com> <5696A19A.2030009@dumbbell.fr> <864mehduk6.fsf@freebsd.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 13/01/2016 22:43, Nikola Pajkovsky wrote: >> I rebuild a full kernel from scratch and it does build fine here. There >> is no "unused variable" warning for me. Do you build a non-debug kernel >> perhaps? I don't plan to build-test such a kernel now, I'll do it when >> the patch is finished. > > Oh, everytime? I have found out, that I use "make buildkernel -DKERNFAST" so only the modifed files are recompiled. I just rebuild the kernel from scratch this time to double-check if I missed a warning. > $ cd sys/modules/drm2 > $ make -j9 > $ make DESTDIR=/boot/ KMODDIR=kernel.i915 install > > is engough (only after I have fully built and booted kernel) Yes, this works fine, but this doesn't use many defaults set by GENERIC, such as debugging options or 32-bit support on 64-bit archs. The problem you hit is likely because I build a debug kernel (the variable is used) and not you (only the declaration remains). > gen6_ggtt_bind_object() > const int max_entries = dev_priv->mm.gtt->gtt_total_entries - first_entry; > BUG_ON(i > max_entries); > > Seems like BUG_ON is noop, which should not be. BUG_ON() is a KASSERT() which is defined to nothing on a non-debug kernel. The variable should be declared in: #if defined(INVARIANTS) ... #endif If you are still willing to send a pull request, you're welcome to do so! I know the change is small, so if you don't feel like cloning an entire repository just for that, I understand and I will fix it. Unlike what I said in my previous email, the pull request should be against the drm-i915-update-38 branch. -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWmKucXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTM8R0QAIPknRRbg0kQRPZxI8NT4bo3 erbkiQyx0JVsjw987IENeHQETaRXFt70g//n2hO8u8uCWCLyn5SKi2/+M4yJrjXi WcHMLDwn94oGlyyF6RyVCVAbY48sdepQ7JTLTuu/u99Qrs8rMZIAz+8PfeaPB0Sh r/wmUFN99qELKIaYS1iQu5A0nIdB0kVsov8qNL6re3GJymKObwzAs7FzeB5ufTZW lopNddkm6++iDTU+NFbEQsdHjEk7/5AcF9whaaNAXANvoKQ5OfVLetjDJ4xqOmV9 9a3iR9S34YW6pRENIXE9g4bgrJANUwU91pC14bE883xQFmE9RMHS7DDRULMY+pmw 21QXqtoEjY7xmBZ2WMYh6nVA7JcPXJnHaL1NtZXjP4vc1g/YOhT3kLyPWHIDBOei It/bD4AlozvYMUEBEKkjxHSlYQDGTiep7l4qdKYNT/F5SSpNoD3Kd4venUS8cHNX fa4jPGd7VjdIdVzPey4lkLWGH5CKDCcvUrqy/2W8IwkmI2GH7Fwp1xQnaexBx9IU QjTMYjg90JpXw5ySd3yGOvkDxAZ71m2rn/+H3el2Mm+Ov+SFmNUGcZcJmhWGKjsh 9UtVhIWIz9r8jPpCigFHEdaKs5uyoUzddVzJwbf7h89OClJiItTFSjnZBF8aRNnx 8zpsSHjeKARNdhDHaat/ =ZC4I -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5698AB9C.9070005>