From nobody Thu Mar 17 10:00:17 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0D1171A179AE; Thu, 17 Mar 2022 10:00:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KK2h15V65z4Std; Thu, 17 Mar 2022 10:00:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647511217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IgE5zFHhpyBYx8jn/AOo/S+42StVFEIJ4m4BgFzNP/M=; b=aHCl1FiojIoaNRbUXWLnFFgYhKParnrHnRFrV7cunH08WSapqEF3WT/eOZnaJQTkVA9h8+ wfMXE9Ntnbh+XlrQFaw6/CfsRpJAldFoLzw3w2CWRzLfgFsuy+TH/kikr68lZLs5fB79d3 5uDoBGjFUrRUdz5QBh9l5ORxJbNtx/N2Nl5bZO6jPMPdEvth8zUX0FG9Cqe7xKQErwbaJ9 0KP8KMEtEzgVidalQkSvD9oGfJAhjInJaujGZA+x8Knx1vDpkRWal3EqD0ZD19M+1ec2gQ ZFsxIGT7XNxpZYBoruEFVQjWgy1MR6Dfl7/CGtZEmTNMSLehv5GwpmpIGKOKlQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3BB5D148; Thu, 17 Mar 2022 10:00:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22HA0Huo088253; Thu, 17 Mar 2022 10:00:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22HA0HJk088247; Thu, 17 Mar 2022 10:00:17 GMT (envelope-from git) Date: Thu, 17 Mar 2022 10:00:17 GMT Message-Id: <202203171000.22HA0HJk088247@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: b5cc52c21d7d - stable/13 - lindebugfs: Zero the linux_file structure before use. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: b5cc52c21d7d34eae93c996cee09e7d2896afa6e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647511217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IgE5zFHhpyBYx8jn/AOo/S+42StVFEIJ4m4BgFzNP/M=; b=ul1rElvVFefVAjwjBr34u6ZFqctOB60yw9is34wRecG1EL4rDOXMI8qEiMb+ByYM2v03Qe /KTROnP0ZanXa4Amt3HcSbnQZyWkIsC6iw2ZxL54NK6KVOjRRZoqRylgHUpf7+ukgPbw7k eLX/f4UwkKdzQo/55/Fv2t7VuT6NBKqWLciGHA4jqeIAnCJrag+UPSr/FW0rlJenIz0GHg RkICT3V54BB56o7UuJNLOPgNQ07F/vN0SoJ6z/1rwPsytXv83GV74EaLKMH5amNg1By557 xBLNc41CzLrswtSgYzqI8yFJaZ/mwrZEOC1yNlXjk2dElvJfZNoaumzhuZ5hiw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647511217; a=rsa-sha256; cv=none; b=WLqfc0jwT414zyg67cBn88LFBJfJ21ACRCWcbO/l9cd4KqskBXy2k3trkJ42fXIUqkdp8b R/cjAiTU+ZG3KdwjJ83dtm4eWE7qswU3sB+ytLNMOwzsJceaHncGjs12rduCGlnmB7swoo cdUuW1KCo7OFzl8O6AKTEWat4xFihhBO02lzOw9UB2Gg1kw8uG2QzC06nkCV/+Cld1q1yo YzqOjHLevxhBOvPyGKWDH736Tk4BUXJQtHWut5AsSLWNZCrXtlbTNvSefPUgpFbH+dHHkn tlFXkTXg7q0gn1ZtU/0zFJGgPZIra7+MBDysVsvTcsG0LMM6CqZulyrsYfmxMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=b5cc52c21d7d34eae93c996cee09e7d2896afa6e commit b5cc52c21d7d34eae93c996cee09e7d2896afa6e Author: Hans Petter Selasky AuthorDate: 2022-03-11 16:29:54 +0000 Commit: Hans Petter Selasky CommitDate: 2022-03-17 09:55:02 +0000 lindebugfs: Zero the linux_file structure before use. This avoids clients using garbage values on the stack and makes debugging easier. Sponsored by: NVIDIA Networking (cherry picked from commit 88a29d89ebab1ed60607c3dab73143c3b59a0f83) --- sys/compat/lindebugfs/lindebugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/lindebugfs/lindebugfs.c b/sys/compat/lindebugfs/lindebugfs.c index 8eaa41412fd2..9507cded9ebd 100644 --- a/sys/compat/lindebugfs/lindebugfs.c +++ b/sys/compat/lindebugfs/lindebugfs.c @@ -117,7 +117,7 @@ static int debugfs_fill(PFS_FILL_ARGS) { struct dentry_meta *d; - struct linux_file lf; + struct linux_file lf = {}; struct seq_file *sf; struct vnode vn; void *buf; @@ -139,7 +139,6 @@ debugfs_fill(PFS_FILL_ARGS) len = sbuf_len(sb); } off = 0; - lf.private_data = NULL; rc = d->dm_fops->open(&vn, &lf); if (rc < 0) { #ifdef INVARIANTS