From nobody Sat Feb 1 02:21:37 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YlGjS63Xhz5mNSX; Sat, 01 Feb 2025 02:21:48 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YlGjS5FkVz3L8f; Sat, 01 Feb 2025 02:21:48 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738376508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCquS5L+FLa6Q8YEF2CSSWkQHuYKcXS+OPYgmPlAs1I=; b=kNDCTgrWNpkxcnQFLQV/L1HIs1Wwq9d7HNOopSSCgemUWQB3tftnQZ9G4X7L8WNtLJyxhl hGxZFQn/xcGiJsVxC6mf0AaSgqMNRQZsaYX1Z5JY2sBimjhsIl99pM0FMmgy8U/uB6fIbu 622rYf966TQGEUCgsXXi2ycT/975Wip1q9D82g0CZez0YKtDJEVpY9dDR4oz97PBBA5yQy SoBz5harSt3XyAScOq3muzPQeJAvMAPs87Cf0PIbhDDxQp6kzDgto61UnnrDuBfy94CoNp 1nfONOUvYoX8CQU9zjcj+Nx067OgERES+io3NI8TzYogpaPQn4x/LNBB2V3M+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738376508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCquS5L+FLa6Q8YEF2CSSWkQHuYKcXS+OPYgmPlAs1I=; b=QpRHRD+UKRhoaN/IYyodBFN8zjHIsH7xjLu/xJrN23NsLeSyIzR1yh+sxPTxTmCDwLiVSV MGdCsPQ9giS2tO+7EgtJA01csy/gXUXNtregvEHDNhNnqGj2pVdOnq/JG41Nro7XbBtqv/ rbK5UXd7Q1HGeHRHyMrLgy96xMN92HCKK6N6VKEV9X/a9kFnC9EHXoBsVn4/T9SjPiEuiC ctK2vVyTNXJ9gfEUi4lcsCbgx6QYfOu94ak93NwefDgt3UKXetgTlOsL2U2kGoZw5U7PjU ab8cVEMF5W1o2uD/pDGOTgm/4pJd9bfZ1gSIz8yj38o+nNJ8O0BFJeUXQQ4Vlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738376508; a=rsa-sha256; cv=none; b=WKVSws3Qv2BTabS3Xm6aBlb2rgSR3raLkXZh5nGLIaSvO+MuSo06jEcDUQwuxFTQDTNj74 WC5pGzQLe4Iof+b92s/7f2DyfAmNOknL7XVa4tQQPKTJKaFaeZl56wVm4yowu1BRfpwDsv JMgCRJUXx99I9tB6dj5hy4Xbf6Ayel9ErbmvZMBHkYQjz8AFJ+5fU4kPbksZgyACkBgRCh dicc6tp4mfLkLV2BXW0Rp4Nk7iOdi0mzo0Nd7Hf/MvYqAV7oeAF/nUoxzReUCXyXG0YeC+ afiXCFe2fkgDydLB2P5d+VvEGkfgv0WOdV9RNq3P21HI0C5XfHiubDpX9e4YuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2001:19f0:6001:9db:98f0:9fe0:3545:10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YlGjR2wfNztGn; Sat, 01 Feb 2025 02:21:47 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: afc38f1f23ac - main - sysctl: Add a regression test which runs sysctl -a From: Zhenlei Huang In-Reply-To: <202501311522.50VFMfQi062320@gitrepo.freebsd.org> Date: Sat, 1 Feb 2025 10:21:37 +0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8668AD0D-5FE3-4C17-A5EB-F0C5862FC62A@FreeBSD.org> References: <202501311522.50VFMfQi062320@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Jan 31, 2025, at 11:22 PM, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dafc38f1f23ac3b579144d0d1d0c3fadf= 735d57bd >=20 > commit afc38f1f23ac3b579144d0d1d0c3fadf735d57bd > Author: Mark Johnston > AuthorDate: 2025-01-31 15:20:04 +0000 > Commit: Mark Johnston > CommitDate: 2025-01-31 15:22:24 +0000 >=20 > sysctl: Add a regression test which runs sysctl -a >=20 > Run sysctl -a during the test suite so that KASAN/KMSAN have a = chance to > catch something. >=20 > Inspired by https://jprx.io/cve-2024-54507/ That's a damn good example ! >=20 > Reviewed by: jhb, emaste > MFC after: 2 weeks > Sponsored by: Klara, Inc. > Differential Revision: https://reviews.freebsd.org/D48659 > --- > sbin/sysctl/tests/sysctl_test.sh | 57 = ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) >=20 > diff --git a/sbin/sysctl/tests/sysctl_test.sh = b/sbin/sysctl/tests/sysctl_test.sh > index e932626a9f14..dfc32a87b212 100644 > --- a/sbin/sysctl/tests/sysctl_test.sh > +++ b/sbin/sysctl/tests/sysctl_test.sh > @@ -1,3 +1,6 @@ > +# > +# SPDX-License-Identifier: BSD-2-Clause > +# > # Copyright (c) 2022 Yoshihiro Ota > # > # Redistribution and use in source and binary forms, with or without > @@ -20,12 +23,64 @@ > # LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN = ANY WAY > # OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY = OF > # SUCH DAMAGE. > +# >=20 > sysctl_name=3D"kern.ostype" > sysctl_value=3D"FreeBSD" > sysctl_type=3D"string" > sysctl_description=3D"Operating system type" >=20 > +atf_test_case sysctl_aflag > +sysctl_aflag_head() > +{ > + atf_set "descr" "Exercise all sysctl handlers" > +} > +sysctl_aflag_body() > +{ > + # Avoid using atf_check here since sysctl -ao generates tons of > + # output and it would all otherwise be saved. > + sysctl -ao >/dev/null 2>stderr > + if [ $? -ne 0 ]; then > + atf_fail "sysctl -ao failed" > + elif [ -s stderr ]; then > + cat stderr > + atf_fail "sysctl -ao printed to stderr" > + fi > +} > + > + > +atf_test_case sysctl_aflag_jail > +sysctl_aflag_jail_head() > +{ > + atf_set "descr" "Exercise all sysctl handlers in a jail" > + atf_set "require.user" "root" > +} > +sysctl_aflag_jail_body() > +{ > + local jail > + > + jail=3Dsysctl_test_aflag_jail > + > + # Avoid using atf_check here since sysctl -ao generates tons of > + # output and it would all otherwise be saved. > + jail -c name=3D$jail command=3Dsysctl -ao >/dev/null 2>stderr > + if [ $? -ne 0 ]; then > + atf_fail "sysctl -ao failed" > + elif [ -s stderr ]; then > + cat stderr > + atf_fail "sysctl -ao printed to stderr" > + fi > + > + jail -c name=3D$jail vnet command=3Dsysctl -ao >/dev/null = 2>stderr > + if [ $? -ne 0 ]; then > + atf_fail "sysctl -ao failed" > + elif [ -s stderr ]; then > + cat stderr > + atf_fail "sysctl -ao printed to stderr" > + fi > +} > + > + > atf_test_case sysctl_by_name > sysctl_by_name_head() > { > @@ -106,6 +161,8 @@ sysctl_nflag_tflag_dflag_body() >=20 > atf_init_test_cases() > { > + atf_add_test_case sysctl_aflag > + atf_add_test_case sysctl_aflag_jail > atf_add_test_case sysctl_by_name > atf_add_test_case sysctl_nflag > atf_add_test_case sysctl_eflag