From owner-dev-commits-src-all@freebsd.org Mon Jan 18 21:34:13 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CAFBD4F660C for ; Mon, 18 Jan 2021 21:34:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DKQ5x5G5vz3Gsm for ; Mon, 18 Jan 2021 21:34:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f49.google.com with SMTP id q18so17825743wrn.1 for ; Mon, 18 Jan 2021 13:34:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0Mek7r33VRbbBP12vVvbyDh+krCfeubQG6zBI0saZiI=; b=f0jYZjx+xDPPaDdZN9Pw+MERuerRDQgkbLs6sqGmR2PugmTFRJpFnp3WLBU0oocr4F 8x53SZpavnNCIGGzDhDmtXbQYcVe8ePYuNzMvzHqgl01SZrckT9ofZsp1KjWnfhR40bi +Va2dE/+PpjhCc74drstUSRALj6bt+qdet2V8iAGjW5x8MLTI44lYGY/2OUz1oZ/bUeO u6PuZ/GjWJTZtj0R9/YCLVUImryH7vD7owZywD51S37u/ZVwErQbQPOxdg1YWMN8LajS OZJKov+5jx7r8sfnvdJiztFhLvdtS9xUL2spOPN4J/5JfzB/+kiGIWQyqW5kZiQwU/0r btiw== X-Gm-Message-State: AOAM532VLSNw863YQcMlpwL8z/4o1uNXql/pgt/UIFsyWcOHJTBvtNQ+ qL4vFlIDAlZSmji6Nc7lgRudqg== X-Google-Smtp-Source: ABdhPJxHLn5n86eov8DTTAFT0gwDDruEHGFqZUSdYVNnCakxbWGFjnhf8YIWG8zYIyCpce2mYYNOOA== X-Received: by 2002:a5d:498a:: with SMTP id r10mr1304713wrq.238.1611005652132; Mon, 18 Jan 2021 13:34:12 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id r1sm33306225wrl.95.2021.01.18.13.34.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2021 13:34:11 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 3b15beb30b3b - main - Implement malloc_domainset_aligned(9). From: Jessica Clarke In-Reply-To: Date: Mon, 18 Jan 2021 21:34:10 +0000 Cc: "Alexander V. Chernikov" , Konstantin Belousov , "src-committers@FreeBSD.org" , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" Content-Transfer-Encoding: quoted-printable Message-Id: <3B09F5B7-25CF-4E1F-8516-9226CB0A5B0E@freebsd.org> References: <202101171729.10HHTsHk099908@gitrepo.freebsd.org> <124361611001207@mail.yandex.ru> To: Konstantin Belousov X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DKQ5x5G5vz3Gsm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2021 21:34:13 -0000 On 18 Jan 2021, at 21:19, Konstantin Belousov = wrote: > On Mon, Jan 18, 2021 at 08:45:43PM +0000, Alexander V. Chernikov = wrote: >> 17.01.2021, 17:30, "Konstantin Belousov" : >>> The branch main has been updated by kib: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3b15beb30b3b4ba17bae3d1d43c8c04f= f862bb57 >>>=20 >>> commit 3b15beb30b3b4ba17bae3d1d43c8c04ff862bb57 >>> Author: Konstantin Belousov >>> AuthorDate: 2021-01-14 03:59:34 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2021-01-17 17:29:05 +0000 >>>=20 >>> Implement malloc_domainset_aligned(9). >> Hi Kostik, >>=20 >> This change makes my vm panic in usb code. No dump, as dumpdev not = mounted yet. >>=20 >> Note: the below lines have been OCR'ed, so there may be some errors. >>=20 >> Root mount waiting for: CAM usbus0 usbus1 >> panic: malloc_domainset_aligned: result not aligned = 0xfffff8000551ca80 size 0x180 align 0x100 >=20 > Try this. >=20 > ... > if (size < align) > - size =3D align; > - res =3D malloc_domainset(size, mtp, ds, flags); > + asize =3D align; > + else if (!powerof2(size)) > + asize =3D roundup2(size, align); > + else > + asize =3D size; Why not just `asize =3D roundup2(size, align)`? It's only 3 instructions (4 on Clang due to a missed combine) on amd64 and I'd be very surprised if the branching version were faster even in the fast path case. Plus it's much easier to read; currently it looks like there's something unusual going on but there really isn't. https://godbolt.org/z/rv6qs7 FWIW Jess