From owner-freebsd-net@freebsd.org  Fri Apr 29 07:16:01 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04BD6B20800
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Fri, 29 Apr 2016 07:16:01 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id D27C5119F
 for <freebsd-net@freebsd.org>; Fri, 29 Apr 2016 07:16:00 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 5C929C1E1; Fri, 29 Apr 2016 07:16:00 +0000 (UTC)
Date: Fri, 29 Apr 2016 07:16:00 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D6120+325+33302b570a7b2b08@reviews.freebsd.org
Subject: [Differential] D6120: tcp/syncache: Set flowid and hash type properly
 for SYN|ACK
Message-ID: <457ae8dced7bb8dea5c47060a0467261@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D6120: tcp/syncache: Set flowid and hash type properly for
 SYN|ACK
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-x2wszzhtr5egla5eo3md>
X-Phabricator-To: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-Cc: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-wo3rxa6lpqbmh4zlzhwf-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-wo3rxa6lpqbmh4zlzhwf-req@FreeBSD.org>
Thread-Index: NTJkNjUzMTU2YzllZDgwNGVmODYwN2NiNWY3IFcjCjA=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2016 07:16:01 -0000

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D6120#130844, @hselasky wrote:
  
  > Basically what you're doing is to loop back the flowid of the received packet - right?
  >
  > Maybe you could put that in a code comment.
  
  
  Yep, since we don't have inp to loopback the SYN's flowid here.  So we use the SYN's flowid directly.  OK, will add.

REVISION DETAIL
  https://reviews.freebsd.org/D6120

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, adrian, rwatson, gnn, lstewart, glebius, delphij, mike-karels.net, jtl, network, transport, hiren, sbruno
Cc: hselasky, freebsd-net-list