From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Nov 6 04:44:12 2003 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BC3E16A4CE for ; Thu, 6 Nov 2003 04:44:12 -0800 (PST) Received: from mail.fs.ei.tum.de (stella.fs.ei.tum.de [129.187.54.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8AAEA4400D for ; Thu, 6 Nov 2003 04:44:06 -0800 (PST) (envelope-from corecode@fs.ei.tum.de) Received: from localhost (localhost [127.0.0.1]) by localhost.fs.ei.tum.de (Postfix) with ESMTP id CC7C530605; Thu, 6 Nov 2003 13:43:57 +0100 (CET) Received: from hydra.fs.ei.tum.de (hydra.fs.ei.tum.de [192.168.113.23]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by mail.fs.ei.tum.de (Postfix) with ESMTP id 2B01D30602; Thu, 6 Nov 2003 13:43:55 +0100 (CET) Date: Thu, 6 Nov 2003 13:43:47 +0100 From: Simon 'corecode' Schubert To: Simon Barner Message-Id: <20031106134347.0e2989bf.corecode@fs.ei.tum.de> In-Reply-To: <20031106013446.GA25025@zi025.glhnet.mhn.de> References: <200311050450.hA54oLUA027741@freefall.freebsd.org> <20031105130540.GB411@zi025.glhnet.mhn.de> <86llqupkad.wl@gray.plala.or.jp> <20031106013446.GA25025@zi025.glhnet.mhn.de> X-Mailer: Sylpheed version 0.9.6claws57 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="pgp-sha1"; boundary="Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy" X-Virus-Scanned: by AMaViS 0.3.12 cc: freebsd-ports-bugs@FreeBSD.org cc: vkushnir@Alfacom.net cc: corecode@corecode.ath.cx cc: fjoe@iclub.nsu.ru Subject: Re: ports/57226: audio/cdparanoia fix to work with cooked_ioctl under -CURRENT X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2003 12:44:12 -0000 --Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit Lately Simon Barner told: > + for (;;) { > -+ arg.nframes = sectors; > -+ if (ioctl(d->ioctl_fd, CDIOCREADAUDIO, &arg) == -1) { > ++ if (ioctl(d->ioctl_fd, CDRIOCSETBLOCKSIZE, &bsize) == -1) > ++ return -7; > ++ if (pread(d->ioctl_fd, p, sectors*bsize, begin*bsize) != sectors*bsize) { > + if (!d->error_retry) > + return -7; > + looks good, but you might want to do the ioctl before the loop. Also, I'd like to drop my maintainership. If you are interested, take it cheers simon -- /"\ http://corecode.ath.cx/#donate \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News --Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/qkIHr5S+dk6z85oRAlY5AKCruei83QT6+bYn83HjHHSOEgzyvwCfeTsA GLZd4S+335D7j0+l982WK0A= =JY9w -----END PGP SIGNATURE----- --Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy--