From owner-freebsd-ports Mon Aug 20 9:20:16 2001 Delivered-To: freebsd-ports@freebsd.org Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by hub.freebsd.org (Postfix) with ESMTP id 235FC37B412; Mon, 20 Aug 2001 09:20:06 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (dialup14-0.iptelecom.net.ua [212.9.229.64]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id TAA71972; Mon, 20 Aug 2001 19:19:57 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.4/8.11.3) with ESMTP id f7KGIeo16949; Mon, 20 Aug 2001 19:18:40 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3B81389A.167A5788@FreeBSD.org> Date: Mon, 20 Aug 2001 19:19:38 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.78 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Akinori MUSHA Cc: portmgr@FreeBSD.org, ports@FreeBSD.org Subject: Re: bsd.port.mk: renaming cookie files References: <86snernc9l.wl@archon.local.idaemons.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Akinori MUSHA wrote: > Hi, > > I'd suggest including ${PKGNAME} in the name of each cookie file, so > that a port would never install the stuff built in the outdated > working directory. > > With the following patch, bsd.port.mk will not think a port is already > built when the PKGNAME doesn't match that of what is built in the > WRKDIR. > > Any comments? Nice idea, but I think that we can go further down the road and change WRKDIR to be ${WRKDIRPREFIX}${.CURDIR}/work-${PKGNAME}. This way we will also protect packages whose distfiles were updated without version bump (hence WRKSRC remains the same) and those that doesn't have version number in their WRKSRC at all (e.g. XFree86) - you know unpacking new version on top of older one can give number of weird problems raging from make (1) not rebuiling all targets to configure script picking pieces of all setup via config.cache file. For compatibility purposed bsd.ports.mk could be tweaked to create work --> work-${PKGNAME}symlink in the ports's top directory. What do you think? -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message