From owner-freebsd-hackers Mon Aug 2 16:45:22 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from awfulhak.org (dynamic-101.max1-du-ws.dialnetwork.pavilion.co.uk [212.74.8.101]) by hub.freebsd.org (Postfix) with ESMTP id 8CFA715080; Mon, 2 Aug 1999 16:45:13 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from keep.lan.Awfulhak.org (root@keep.lan.Awfulhak.org [172.16.0.8]) by awfulhak.org (8.9.3/8.9.3) with ESMTP id XAA01311; Mon, 2 Aug 1999 23:15:53 +0100 (BST) (envelope-from brian@lan.awfulhak.org) Received: from keep.lan.Awfulhak.org (brian@localhost.lan.Awfulhak.org [127.0.0.1]) by keep.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id XAA02577; Mon, 2 Aug 1999 23:17:01 +0100 (BST) (envelope-from brian@keep.lan.Awfulhak.org) Message-Id: <199908022217.XAA02577@keep.lan.Awfulhak.org> X-Mailer: exmh version 2.0.2 2/24/98 To: Warner Losh Cc: Bill Fumerola , committers@FreeBSD.ORG, hackers@FreeBSD.ORG Subject: Re: Mentioning RFC numbers in /etc/services In-reply-to: Your message of "Mon, 02 Aug 1999 11:32:15 MDT." <199908021732.LAA07269@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 02 Aug 1999 23:17:01 +0100 From: Brian Somers Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG [.....] > @@ -832,15 +833,21 @@ > if (!sep->se_rpc) { > sp = getservbyname(sep->se_service, sep->se_proto); > if (sp == 0) { > + if ((p = strtol(sep->se_service, > + (char **NULL), 10))) { > + sep->se_ctrladdr.sin_port = htons(p); > + goto numeric_override; > + } > syslog(LOG_ERR, "%s/%s: unknown service", > sep->se_service, sep->se_proto); > sep->se_checked = 0; > continue; > } > if (sp->s_port != sep->se_ctrladdr.sin_port) { > + sep->se_ctrladdr.sin_port = sp->s_port; > +numeric_override: > sep->se_ctrladdr.sin_family = AF_INET; > sep->se_ctrladdr.sin_addr = bind_address; > - sep->se_ctrladdr.sin_port = sp->s_port; > if (sep->se_fd >= 0) > close_sep(sep); > } [.....] Yes, but do it the other way 'round - strtol first, if it's not all numeric, getservbyname(). -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message