From owner-freebsd-fs@FreeBSD.ORG Fri Jan 14 18:35:02 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C91B5106564A; Fri, 14 Jan 2011 18:35:02 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [64.81.247.49]) by mx1.freebsd.org (Postfix) with ESMTP id 8AF7A8FC15; Fri, 14 Jan 2011 18:35:02 +0000 (UTC) Received: from chez.mckusick.com (localhost [127.0.0.1]) by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id p0EIZ1G1049852; Fri, 14 Jan 2011 10:35:02 -0800 (PST) (envelope-from mckusick@chez.mckusick.com) Message-Id: <201101141835.p0EIZ1G1049852@chez.mckusick.com> To: Bruce Evans In-reply-to: <20110114170710.R28039@besplex.bde.org> Date: Fri, 14 Jan 2011 10:35:01 -0800 From: Kirk McKusick Cc: freebsd-fs@freebsd.org, Sergey Kandaurov Subject: Re: Minor change in ufs_quota.c uprintf() fmt X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2011 18:35:02 -0000 I appreciate your detailed analysis of these changes :-) Overall I think that the proposed changes do improve the readability of the code and given that the string concatenation does meet the C99 standard (as opposed to being a gcc'ism) can be expected to be reasonably portable at this time. Kirk McKusick