From owner-svn-src-all@freebsd.org Fri Jan 19 04:38:58 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7699CEC1A5F; Fri, 19 Jan 2018 04:38:58 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-ot0-x241.google.com (mail-ot0-x241.google.com [IPv6:2607:f8b0:4003:c0f::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 398EC71043; Fri, 19 Jan 2018 04:38:58 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-ot0-x241.google.com with SMTP id a24so418988otd.4; Thu, 18 Jan 2018 20:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nwYc1j2ggL/XVWAgpfH2q4uQEhiBonj57LwYZbt7U1E=; b=Fuf7/gMZDSmMo0tX49LY7N+SsStVqv8M+sjkwsKw/kUoK2pJQwRQ4ao+C0IyvwxpcX e+FPLboViMLgy9dHvS5lnpChimEk7XpRtoVpM73RwDKj94TZX3G+YzEmko/Mgzuab+1t cB8mcY0BkHeDLStE+0DUIwA/JQtpj6VnddaGhIkG2+XwtZdbta2Dyk+6kFc/JIDe9YWQ oK40itebnF1WMaOl+nQgn8oozTNCKTAZaIHk0m9UJHKWumSUCOILIl/WSLSJe9XWnXMm w34KMJKxqEvnTog49i22fp354p1wdRFpYICqrsN5hZl2s115qB1OzAayDb5EQle0FyH4 Qk2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nwYc1j2ggL/XVWAgpfH2q4uQEhiBonj57LwYZbt7U1E=; b=rPuCdGi8jX4x3qnFJdcUGY+ZQFIyCQZyny8/wHHkuQC1qcFdiJz7Kf2BScUnFJSRWY JQgxJEpOwn/nAXOfKN5YxaJtGynPT9X64pfnBrECS31BOHktJPm1vY8G6vBTuSv3pcOD qBVHrila69hbzNqlFscikGWvZ2zW1cmGNeCngxpSDa1pvsRQM/adwxzHklaFVn55/GJV pfV48sfDVXljfxXbS+3ZpPVBv1ez6DtnEureZqnl6zxFfEdb7V3rHVBDYqs8SV+BK+w3 uYohVwsGDoi2m3VA9G8gdEE8MiakLyGe06N76ov7SZHLUeeKcbTogUnt1TcpAYmzxg8f y4Cw== X-Gm-Message-State: AKwxyteJ95W/NdsbJ5/wIzqOAh0KG7rRJ5FAY1V2MfK+qN+CP1nkKVF4 lN0xQjAekFY9/rbGkwP1tK5+eipOKVkRS+ussFk9HA== X-Google-Smtp-Source: ACJfBovdxTEjAQcbHpu99Ubm5YO21C5WtRipY62T87WYYHhtW61xFYB52H5PeqrHkUsjL0VJ/57HnUA66ChprCAiE58= X-Received: by 10.157.113.201 with SMTP id z9mr4605650otj.164.1516336737298; Thu, 18 Jan 2018 20:38:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.63.10 with HTTP; Thu, 18 Jan 2018 20:38:56 -0800 (PST) In-Reply-To: <201801190434.w0J4Y6i7086677@repo.freebsd.org> References: <201801190434.w0J4Y6i7086677@repo.freebsd.org> From: Benjamin Kaduk Date: Thu, 18 Jan 2018 22:38:56 -0600 Message-ID: Subject: Re: svn commit: r328159 - head/sys/modules To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 04:38:58 -0000 On Thu, Jan 18, 2018 at 10:34 PM, Conrad Meyer wrote: > Author: cem > Date: Fri Jan 19 04:34:06 2018 > New Revision: 328159 > URL: https://svnweb.freebsd.org/changeset/base/328159 > > Log: > Unbreak i386 build > > The logical result of a right shift >= the width of a type is zero, but > our > compiler decides this is a warning (and thus, error). Just remove ccp(4) > from i386. > That may seem like the logical result, but this is actually undefined behavior. Per n1256.pdf, section 6.5.7: The integer promotions are performed on each of the operands. The type of the result is that of the promoted left operand. If the value of the right operand is negative or is greater than or equal to the width of the promoted left operand, the behavior is undefined. -Ben