From owner-freebsd-arch@freebsd.org Fri Jul 6 20:46:17 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8877102B15C for ; Fri, 6 Jul 2018 20:46:16 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6BEA2964F9 for ; Fri, 6 Jul 2018 20:46:16 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 2C548102B149; Fri, 6 Jul 2018 20:46:16 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF2EE102B142 for ; Fri, 6 Jul 2018 20:46:15 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69001964F6; Fri, 6 Jul 2018 20:46:15 +0000 (UTC) (envelope-from hackagadget@gmail.com) Received: by mail-oi0-x235.google.com with SMTP id k12-v6so25742609oiw.8; Fri, 06 Jul 2018 13:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XAASetulMzAxNa2CfSdlCPHnZ0+T+TpKSlPcLldQUdo=; b=UbcbBBqbhRj0KZnoyLCnuoYlb5ye6gjq9IFLKRSk6rVntqjhvKATrnGWDKgQy/O4yW Qg1igehLGi5Y9CXoULRk7QWy3CsFjo42XFdEehSKI+5DAhWAVLgtQaQ8IS/T8cQrLQtm xllyqfPfh0xJtC02+12M5NAg4bXN8i/1/9t4HccO1JN2NaCMqoI6lu2dsUTTEFUX0SPa J+2dWHUmPGXGgswBinA7f0N4r/Z4zGO0BX19Gr4g+yDWsX0AviFlzdQKc4neygLoqw86 isMcl/HVAh4vg17Xa3jSu+H87CjXpYF/srHKa9GaERQaoeBuWHWyX4NuVt+2vE4lPmAC bFmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XAASetulMzAxNa2CfSdlCPHnZ0+T+TpKSlPcLldQUdo=; b=FE7TtTure/L/NnANAduN/BQuOTR5SjfR/cjxdEPOBjxfX4jBHiPPPqpL3oF06FgYqG 8qpyKGTBb0A8lT1Ea0FHfSVY4EtoLFdUEsPYrMHwBYDPG1ukDa5Mieuki2qJKPfrKnWD i44XpDo/NZdYZZ/T9jXtoplpg9Ys1MFdEX/wEcHBoqBpQv01r8uWWnS5se8PllDRQXHn E/XDJ4Sruyl8/2XR7l6ytJTgz1zjWO7pkT0i8CpbLJqNBAMDRLxwKmZbxQrlNVPfkQXG H09EsqmAgYyBuAkgQ3dFsj6020Dm9uXNCTMY5xEywu/k0uVgH/FfbJaQOZ2oGrLnRKZS 32PA== X-Gm-Message-State: APt69E0ImZbIaEQE2iV5XirEcpVpntb9TJP9RBorj5GCpPtaDwby+V25 GcE00XP5DHy6sNQg3uTvamHc6H5ezc3+17a8mL81Ww== X-Google-Smtp-Source: AAOMgpfBIMU86wNP8v2/sloqN7jTZEi4VMZ5AQ1VZ66YH3/eaO1LrPmyl8UwOfn9hSHs/1xm4hw2hae0w2nbQomVEic= X-Received: by 2002:aca:100f:: with SMTP id 15-v6mr14007118oiq.110.1530909974248; Fri, 06 Jul 2018 13:46:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:b0e:0:0:0:0:0 with HTTP; Fri, 6 Jul 2018 13:46:13 -0700 (PDT) In-Reply-To: References: From: Stephen Kiernan Date: Fri, 6 Jul 2018 16:46:13 -0400 Message-ID: Subject: Re: Veriexec To: cem@freebsd.org Cc: "freebsd-arch@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 20:46:17 -0000 On Fri, Jul 6, 2018 at 4:29 PM, Conrad Meyer wrote: > Hi Stephen, > > On Fri, Jul 6, 2018 at 1:09 PM, Stephen Kiernan > wrote: > > On Thu, Jul 5, 2018 at 2:06 PM, Conrad Meyer wrote: > >> (Additionally, I don't really like the use of > >> "revert" (as used in the commit message) or "backout" (here) to > >> describe the kernel changes. The bad code is still present, but > >> disabled by default.) > > > > What would you prefer? It helps to provide an alternative if you wish t= o > > see someone potentially use it in the future. You simply stated you > didn't > > like the use without providing an alternative. > > It's a minor language quibble =E2=80=94 don't worry about it too much. I > would suggest "disable by default," for example. "Revert" and > "backout" have a specific meaning that is approximately 'svn merge -c > -NNNNNN'. > > > Note that the commit message for r335682 says "Partial revert of > > r335399 and r335400" which is exactly what it is. It wasn't a full reve= rt > > of the commits, it was only partially reverting them. > > It removes 7 lines out of 2856 lines added in the two commits. I > agree that you're technically correct =E2=80=94 it is a partial revert. = But I > think it would be more clear and accurate not to describe it as any > kind of revert, given how little (0.25% of lines) was actually > removed. > Fair enough. Thanks. -Steve