From owner-freebsd-bugs@freebsd.org  Wed Jun 29 19:38:19 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7BD3CB86D62
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 29 Jun 2016 19:38:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6C0762EA1
 for <freebsd-bugs@FreeBSD.org>; Wed, 29 Jun 2016 19:38:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u5TJcJ8I095818
 for <freebsd-bugs@FreeBSD.org>; Wed, 29 Jun 2016 19:38:19 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 210707] freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious
 condition
Date: Wed, 29 Jun 2016 19:38:19 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: dcb314@hotmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-210707-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 19:38:19 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210707

            Bug ID: 210707
           Summary: freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious
                    condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

1.

freebsd/sys/dev/aacraid/aacraid.c:2854]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error =3D copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t)) !=3D 0))
        goto out;

Maybe better code

    if ((error =3D copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t))) !=3D 0)
        goto out;

2.

freebsd/sys/dev/aacraid/aacraid.c:2861]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error =3D copyin((void *)user_srb, srbcmd, fibsize) !=3D 0))

Maybe better code

    if ((error =3D copyin((void *)user_srb, srbcmd, fibsize)) !=3D 0)

--=20
You are receiving this mail because:
You are the assignee for the bug.=