Date: Sat, 16 Nov 2002 23:03:09 -0800 From: Alfred Perlstein <alfred@FreeBSD.org> To: Garrett Wollman <wollman@lcs.mit.edu> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_aio.c src/lib/libc/gen sysconf.c src/sys/posix4 posix4.h posix4_mib.c Message-ID: <20021117070309.GH6882@elvis.mu.org> In-Reply-To: <200211170657.gAH6vQ7G000452@khavrinen.lcs.mit.edu> References: <200211170415.gAH4FYwL022645@repoman.freebsd.org> <200211170657.gAH6vQ7G000452@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
* Garrett Wollman <wollman@lcs.mit.edu> [021116 22:57] wrote: > <<On Sat, 16 Nov 2002 20:15:34 -0800 (PST), Alfred Perlstein <alfred@FreeBSD.org> said: > > > posix4_mib.c: > > Initialize the aio configuration parameters to -1 > > to indicate that it is not loaded. > > Add a facility (p31b_iscfg()) to determine if a posix4 facility has been > > initialized to avoid having to re-order the SYSINITs. > > Use p31b_iscfg() to determine if aio has had a chance to run yet which > > is likely if it is compiled into the kernel and avoid spamming its > > values. > > Introduce a macro P31B_VALID() instead of doing the same comparison over > > and over. > > Everything in this file is utterly bogus and should be replaced with > normal sysctls in the relevant source files. You have done quite a > lot of work to work around this bug; it might have been easier to just > fix it. I can take a shot at that. No promises though. :) In the future when I come to you for advice I'd really appreciate it if you'd attempt to think one step ahead of me, especially if you have strong opinions on how something should be done. Basically I really don't care how it's fixed, but I'd like it to be as clean in your eyes as possible, so please either take the initiative and suggest the one true way or feel free to step in and clean up any mess I may have made and I assure you I won't object. :) I think part of the problem was that posix4 was optional before, with it now manditory I think I can just SYSCTL_DECL the p31b top of tree and move the relevant branches directly into the aio code. Let me know if you have a better way of doing this and I'll take a shot at it. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021117070309.GH6882>