From owner-cvs-all  Sun Jun  4 19:41:16 2000
Delivered-To: cvs-all@freebsd.org
Received: from florence.pavilion.net (florence.pavilion.net [212.74.0.25])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2A17137BD45; Sun,  4 Jun 2000 19:41:02 -0700 (PDT)
	(envelope-from joe@pavilion.net)
Received: from genius.systems.pavilion.net (genesis.tao.org.uk [194.242.131.254])
	by florence.pavilion.net (8.9.3/8.8.8) with ESMTP id DAA33962;
	Mon, 5 Jun 2000 03:40:57 +0100 (BST)
	(envelope-from joe@pavilion.net)
Received: by genius.systems.pavilion.net (Postfix, from userid 100)
	id BDE8882; Mon,  5 Jun 2000 03:41:22 +0100 (BST)
Date: Mon, 5 Jun 2000 03:41:22 +0100
From: Josef Karthauser <joe@pavilion.net>
To: "Andrey A. Chernov" <ache@FreeBSD.ORG>
Cc: Josef Karthauser <joe@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/bin/ls Makefile extern.h ls.c ls.h print.c
Message-ID: <20000605034122.T620@pavilion.net>
References: <200006050214.TAA18352@freefall.freebsd.org> <20000604193146.B3141@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20000604193146.B3141@freebsd.org>; from ache@FreeBSD.ORG on Sun, Jun 04, 2000 at 07:31:46PM -0700
X-NCC-RegID: uk.pavilion
Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England
Phone: +44-845-333-5000
Fax: +44-845-333-5001
Mobile: +44-403-596893
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sun, Jun 04, 2000 at 07:31:46PM -0700, Andrey A. Chernov wrote:
> On Sun, Jun 04, 2000 at 07:14:01PM -0700, Josef Karthauser wrote:
> > joe         2000/06/04 19:14:01 PDT
> > 
> >   Modified files:
> >     bin/ls               Makefile extern.h ls.c ls.h print.c 
> >   Log:
> >   * Re-implement colour support using termcap's AF and AB capabilities
> >     to manage the ANSI colour sequences.  Colour support is disabled
> >     unless the TERM environment variable references a valid termcap.
> 
> ansiseq = tgetstr("se", &bp);
> 
> This is wrong way to turn colors off. "se" for attributes, not for colors.
> This is very inefficient and cause full termcap entry search each time.

Forget the inefficiency for a mo, I'll fix it in a bit.

What is the correct capability for switching colours off?  The 'se'
produces the same ANSI sequence that asami was using in his patches,
what should he have been using?

Joe


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message