From owner-svn-src-all@FreeBSD.ORG Sun Jun 19 18:09:45 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52B261065670; Sun, 19 Jun 2011 18:09:45 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id CA6758FC14; Sun, 19 Jun 2011 18:09:44 +0000 (UTC) Received: by vws18 with SMTP id 18so481302vws.13 for ; Sun, 19 Jun 2011 11:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:content-type; bh=Sgj7G3st4e0+ZeurWeU39BOrlnZ2APQh5fL0g55mPH8=; b=HNwbiUHE0GCaxrmYYJmukuhOfHZqhAJCHz5K2y/dOQWYeLbVD+cfq3+QWsLmgOmMjA s0DQe/3ehg6c3mfGupIl2CQSvmDBI4o7cfQhU0EAVFVv9XDA+y/Y8OmqY0V5TaLYwxtP JQVuPLL8t9y/cp8jjD8IjDSpLvgn5sASu4hW0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=ZdwE/L0mJekHmfv1diiI+c3LyY7C9b83OWSQjUypxWRZLly+Hb0WBEArhh/dJfXwWU 4RR3aKNqbJOQ9XcaDwdoJNW6BZR3/MA5cHrJSP8ie7toWL4u4g2HT0Ea2q3YdNvnWm8N 6n3qCVt/GhEgJ8k56cKGsP4H8CDv8iG9rIcJM= Received: by 10.52.94.50 with SMTP id cz18mr2357033vdb.299.1308506983776; Sun, 19 Jun 2011 11:09:43 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id l31sm263957vbr.23.2011.06.19.11.09.41 (version=SSLv3 cipher=OTHER); Sun, 19 Jun 2011 11:09:42 -0700 (PDT) Date: Sun, 19 Jun 2011 14:09:34 -0400 From: Alexander Kabaev To: Craig Rodrigues Message-ID: <20110619140934.08375095@kan.dnsalias.net> In-Reply-To: <201106152213.p5FMDMWP000491@svn.freebsd.org> References: <201106152213.p5FMDMWP000491@svn.freebsd.org> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/ilJimhLH9t.o+OsibXxI69z"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223124 - head/lib/libstand X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2011 18:09:45 -0000 --Sig_/ilJimhLH9t.o+OsibXxI69z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Jun 2011 22:13:22 +0000 (UTC) Craig Rodrigues wrote: > Author: rodrigc > Date: Wed Jun 15 22:13:22 2011 > New Revision: 223124 > URL: http://svn.freebsd.org/changeset/base/223124 >=20 > Log: > (1) When sending the TFTP RRQ packet to read a file, > send along the "blksize" option specified in RFC2348, > and the "tsize" option specified in RFC2349. > =20 > Add code to parse the TFTP Option Acknowledgement (OACK) > packet as specified in RFC2347. > =20 > For TFTP servers which support the "blksize" option, we can > specify a TFTP Data block size larger than the default 512 > bytes specified in RFC1350. This offers greater read performance when > downloading files. > =20 > We request an initial size of 1428 bytes, which is less than > the Ethernet MTU of 1500 bytes. If the TFTP server sends back an OACK > packet, then use the block size specified in the OACK packet. > Most times it is usually the same value as what we request. > If the TFTP server supports RFC2348, we will see performance > improvements by transferring files over TFTP with larger block sizes. > =20 > If we do not get back an OACK packet, then we most likely we > are interoperating with a legacy TFTP server that does not > support TFTP extension options, so default to the block size of > 512 bytes. > =20 > (2) If the "tftp.blksize" environment variable is set, then > take that value and use it when sending the TFTP RRQ packet, > instead of 1428. This allows us to set different values of > "tftp.blksize" in the loader, so that we can test out different > TFTP block sizes at run time. > =20 > Obtained from: Juniper Networks > Fixed by: rodrigc >=20 Has this code been reviewed by anyone outside of Juniper? --=20 Alexander Kabaev --Sig_/ilJimhLH9t.o+OsibXxI69z Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iD8DBQFN/jtkQ6z1jMm+XZYRAkPjAJwNCaXWx//1zVtErp9TxMC7JsaReACgsWda YJc3I++q8CjXfupQNUTyVNc= =kwQG -----END PGP SIGNATURE----- --Sig_/ilJimhLH9t.o+OsibXxI69z--