From owner-svn-src-all@FreeBSD.ORG Mon Dec 6 19:23:26 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6CB1106564A; Mon, 6 Dec 2010 19:23:26 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 16E808FC0A; Mon, 6 Dec 2010 19:23:25 +0000 (UTC) Received: by vws9 with SMTP id 9so5029517vws.13 for ; Mon, 06 Dec 2010 11:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=ivB32G87nmtPlYbjdm0uRIn0FslCZZvD3MKz7HP8f10=; b=ul0UjI7dbwlUDnCDo5a0ibqTxyGXaCQZfychB8wLTPYrdoFe9W0NeyWMF9PmVlzQoV 8fInXo5RAzPOeAImTlNcXdTXD99UGkQcWo4nyVVqdfO+GvTjNZ9XQ2w7LuP/C+yIEfJ+ P568DqfII86LSON1YNmFUzkuNNZUPtA1fNC2k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=PD0LpKjgZAVqbjkxY7Uni2oNSHH6+yZjiaCYs8pO3EMXm2AqvI8E17Vxwy7GHVGPF3 kdzPZhk3/MVbfPCM/aStdyj6y7TOffFOAxyPa9HDUBryVsl6mqwXtJjol3QkqvUrNm5y vAjaxlhtusctH4UwOr5dh5z2kQQ5KjcU4aE5I= Received: by 10.229.228.146 with SMTP id je18mr4879453qcb.47.1291663404130; Mon, 06 Dec 2010 11:23:24 -0800 (PST) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.229.231.143 with HTTP; Mon, 6 Dec 2010 11:22:43 -0800 (PST) In-Reply-To: <20101206184453.GA1936@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> From: Ivan Voras Date: Mon, 6 Dec 2010 20:22:43 +0100 X-Google-Sender-Auth: LiO46Q5s-hfyeopxGNF_cYIEUVs Message-ID: To: Pawel Jakub Dawidek Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 19:23:26 -0000 On 6 December 2010 19:44, Pawel Jakub Dawidek wrote: > On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: >> Author: ivoras >> Date: Mon Dec =C2=A06 12:18:02 2010 >> New Revision: 216230 >> URL: http://svn.freebsd.org/changeset/base/216230 >> >> Log: >> =C2=A0 Use GEOM stripesize field when calculating ashift. This will enab= le correct >> =C2=A0 alignment on drives with large sector sizes (e.g. 4 KiB) but the >> =C2=A0 implementation might need to be revisited if devices with large s= tripesizes >> =C2=A0 appear (e.g. if RAID controllers or flash drives start using the = field), >> =C2=A0 probably by introducing a physsectorsize field in GEOM providers. > > Please back this out as soon as possible! Given information such as this: http://www.solarismen.de/archives/5-Solaris-and-the-new-4K-Sector-Disks-e.g= .-WDxxEARS-Part-2.html http://article.gmane.org/gmane.os.solaris.opensolaris.zfs/43986 and my last message on the subject in the thread: http://permalink.gmane.org/gmane.os.freebsd.devel.geom/4376 Can you explain why is it wrong, and what can go wrong with changing ashift in this way?