From owner-freebsd-emulation@FreeBSD.ORG Sun Apr 13 19:26:21 2008 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F579106564A; Sun, 13 Apr 2008 19:26:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id B8B348FC19; Sun, 13 Apr 2008 19:26:20 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Jl7qE-000Edl-Ry; Sun, 13 Apr 2008 22:26:19 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3DJQMiT052763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 13 Apr 2008 22:26:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3DJQE2d093244; Sun, 13 Apr 2008 22:26:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m3DJQEct093243; Sun, 13 Apr 2008 22:26:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 13 Apr 2008 22:26:14 +0300 From: Kostik Belousov To: Chagin Dmitry Message-ID: <20080413192614.GC18958@deviant.kiev.zoral.com.ua> References: <20080412181712.Y38920@ora.chd.net> <20080412145401.GA4139@freebsd.org> <20080413214624.S7426@ora.chd.net> <20080413183248.GA68642@freebsd.org> <20080413183659.GA18958@deviant.kiev.zoral.com.ua> <20080413231135.K1079@ora.chd.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XWOWbaMNXpFDWE00" Content-Disposition: inline In-Reply-To: <20080413231135.K1079@ora.chd.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua X-Scanner-Signature: e5a023dad48cfed04c9aaaf8a25ccfed X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2617 [Apr 11 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: freebsd-emulation@freebsd.org, bsam@freebsd.org Subject: Re: Call for review && test: linux_kdump-1.6 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 19:26:21 -0000 --XWOWbaMNXpFDWE00 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 13, 2008 at 11:11:55PM +0400, Chagin Dmitry wrote: > On Sun, 13 Apr 2008, Kostik Belousov wrote: >=20 > >On Sun, Apr 13, 2008 at 08:32:48PM +0200, Roman Divacky wrote: > >>On Sun, Apr 13, 2008 at 09:58:08PM +0400, Chagin Dmitry wrote: > >>>On Sat, 12 Apr 2008, Roman Divacky wrote: > >>> > >>>>>And question: whether i can add to linuxolator some ktr_struct > >>>>> functionality? > >>>> > >>>>sure... please provide a patch and I'll take care about it. > >>> > >>>ok, thnx :) > >>>what about EJUSTRETURN? > >>>i attached simple patch for demo only (not tested). > >> > >>uh... can you provide diff -u ? I dont understand the diff at all ;) > > > >Also, please note that the ML software strips your attachments. Either > >inline the patch, or use the plain-text content-type for it. > > >=20 > ups... ah google )) > i have understood, sorry and thnx. > Speech about that in linux_kdump it is impossible to distinguish > EJUSTRETURN from a real error. look: >=20 > --- sys/i386/i386/trap.c.orig 2008-04-13 21:39:18.000000000 +0400 > +++ sys/i386/i386/trap.c 2008-04-13 22:35:25.000000000 +0400 > @@ -1091,8 +1091,12 @@ > td->td_proc->p_pid, td->td_name, code); >=20 > #ifdef KTRACE > - if (KTRPOINT(td, KTR_SYSRET)) > - ktrsysret(code, error, td->td_retval[0]); > + if (KTRPOINT(td, KTR_SYSRET)) { > + if (error =3D=3D EJUSTRETURN) > + ktrsysret(code, 0, td->td_retval[0]); > + else > + ktrsysret(code, error, td->td_retval[0]); > + } > #endif >=20 > /* > @@ -1104,4 +1108,3 @@ >=20 > PTRACESTOP_SC(p, td, S_PT_SCX); > } > - I do not quite understand the intent of this change. EJUSTRETURN is used for two different purposes in the kernel. 1. The sigreturn family of the syscalls use it after the interrupted frame is restored to avoid the normal syscall return sequence to modify the machine state. 2. It is used by the kernel to notify the in-kernel caller code about some special condition, that nonetheless shall not be returned to the userspace. Only the first case is applicable to the kdump, and IMHO you actually destroy some information, since error =3D=3D EJUSTRETURN is reported as 0. Could you, please, provide some more arguments in the support of your proposed change ? --XWOWbaMNXpFDWE00 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkgCXlYACgkQC3+MBN1Mb4ihJgCg57xq2ftlYsydi5zgGFZUTXzl pAkAoPFrs3M3PmKKgBfw8z3veyBZoW32 =g7d0 -----END PGP SIGNATURE----- --XWOWbaMNXpFDWE00--