From owner-freebsd-net Thu Apr 27 10:40:10 2000 Delivered-To: freebsd-net@freebsd.org Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7]) by hub.freebsd.org (Postfix) with ESMTP id 9385337B94F; Thu, 27 Apr 2000 10:40:02 -0700 (PDT) (envelope-from archie@whistle.com) Received: (from archie@localhost) by bubba.whistle.com (8.9.3/8.9.2) id KAA66052; Thu, 27 Apr 2000 10:40:01 -0700 (PDT) From: Archie Cobbs Message-Id: <200004271740.KAA66052@bubba.whistle.com> Subject: Re: Proposal for ethernet, bridging, netgraph In-Reply-To: <200004262034.WAA45549@luxren2.boostworks.com> from Remy Nonnenmacher at "Apr 26, 2000 10:34:31 pm" To: committers@freebsd.org Date: Thu, 27 Apr 2000 10:40:01 -0700 (PDT) Cc: freebsd-net@freebsd.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org CC: to -committers I'm planning to check in this patch soon: ftp://ftp.whistle.com/pub/archie/misc/net.cleanup.patch.3 The goal of the patch is simply to move the BPF and BRIDGE taps on Ethernet frame input from the individual drivers up into ether_input(), while attempting to preserve any existing "avoid unnecessarily reading packets" optimizations (specifically in the if_ed.c and if_ie.c drivers). The result: 1140 lines removed 187 lines added This patch has been reviewed by freebsd-net already, but I'm trying to give a lot of warning because.. o I don't have all 47 types of Ethernet cards to test. In fact my -current machine only has one so I can't even test BRIDGE'ing. At least BPF still works :-) o It's not completely clear which drivers are shared with other versions of 'BSD -- if I've missed any, they will need some #ifdef __FreeBSD__ modifications. Thanks! -Archie P.S.: there are lots of other "cleanups" that could be done; please discuss these on freebsd-net (i.e., remove -committers). ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message