From owner-freebsd-threads@FreeBSD.ORG Fri Nov 27 19:14:00 2009 Return-Path: Delivered-To: threads@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66CA31065697 for ; Fri, 27 Nov 2009 19:14:00 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id BE2CF8FC13 for ; Fri, 27 Nov 2009 19:13:59 +0000 (UTC) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id nARJG5XJ041541; Fri, 27 Nov 2009 14:16:05 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Kostik Belousov In-Reply-To: <20091127131242.GA2368@deviant.kiev.zoral.com.ua> References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-LTOyvPKDd72Gw9J7NAOr" Organization: FreeBSD, Inc. Date: Fri, 27 Nov 2009 14:14:08 -0500 Message-Id: <1259349248.1608.36.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: threads@FreeBSD.org Subject: Re: [PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 19:14:00 -0000 --=-LTOyvPKDd72Gw9J7NAOr Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2009-11-27 at 15:12 +0200, Kostik Belousov wrote: > On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote: > > I would like permission to commit this patch which adds missing > > pthread_condattr_{init,destroy} symbols to libc. I think I did the > > symbol addition correctly (and it seems to work). Without this, the > > weak symbols added in the libpthread-stubs port conflict with those in > > libthr, and applications with use these symbols can crash. > >=20 > > I have temporarily hacked libpthread-stubs to fix this, but I really > > feel these stubs should be added to libc. I've also copied kib as he > > has been kind enough to review my work in the past. Thanks. > >=20 > > http://www.marcuscom.com/downloads/stubs.diff >=20 > It is FBSD_1.2 version that we use for symbols added after HEAD become > CURRENT-9. Done. >=20 > I think that you shall change lib/libc/libc_private.h, adding > corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT > indexes. >=20 > Is the patch buildable ? Yes, but only because my machine had the libc_private.h chunk which I forgot in the diff. >=20 > Interesting question is whether these changes are mergeable to the > stable branch. Possibly yes, if we declare that rtld/libc/libthr shall > be built from the consistent source snapshot. I would like to merge these changes to RELENG_8, RELENG_7, and RELENG_6 if possible. Anything which depends on dbus (e.g. GNOME) will just crash without them. In the meantime, I have hacked libpthread-stubs, but I really think this is the more correct fix. http://www.marcuscom.com/downloads/stubs.diff Thanks for the review. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-LTOyvPKDd72Gw9J7NAOr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAksQJQAACgkQb2iPiv4Uz4cDzACgksqz1AgY3wYLalYIEbnymzHQ 9+cAoIbhhO/4EAGQ7x1tc8MOLiKYyvS6 =cVKV -----END PGP SIGNATURE----- --=-LTOyvPKDd72Gw9J7NAOr--