Date: Thu, 9 Jun 2005 17:30:15 GMT From: Kris Kennaway <kris@obsecurity.org> To: freebsd-amd64@FreeBSD.org Subject: Re: amd64/82071: incorrect -march's parameter to build 32bit libraries Message-ID: <200506091730.j59HUF5x026589@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR amd64/82071; it has been noted by GNATS.
From: Kris Kennaway <kris@obsecurity.org>
To: Shusnuke SHINOMIYA <shino@fornext.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: amd64/82071: incorrect -march's parameter to build 32bit libraries
Date: Thu, 9 Jun 2005 13:27:27 -0400
--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jun 09, 2005 at 02:57:58PM +0000, Shusnuke SHINOMIYA wrote:
>=20
> >Number: 82071
> >Category: amd64
> >Synopsis: incorrect -march's parameter to build 32bit libraries
> >Confidential: no
> >Severity: serious
> >Priority: high
> >Responsible: freebsd-amd64
> >State: open
> >Quarter: =20
> >Keywords: =20
> >Date-Required:
> >Class: sw-bug
> >Submitter-Id: current-users
> >Arrival-Date: Thu Jun 09 15:00:32 GMT 2005
> >Closed-Date:
> >Last-Modified:
> >Originator: Shusnuke SHINOMIYA
> >Release: FreeBSD/amd64 5.4-STABLE
> >Organization:
> >Environment:
> FreeBSD walnut.net.ss.titech.ac.jp 5.4-STABLE FreeBSD 5.4-STABLE #0: Sat =
May 7 15:57:39 JST 2005 shino@walnut.net.ss.titech.ac.jp:/usr/obj/usr/=
src/sys/WALNUT amd64
>=20
> >Description:
> In src/Makefile.inc1, -march's parameter is hard-coded as athlon-xp in or=
der to build 32bit libraries.
> But, I think appropriate -march in Intel Xeon environment is prescott.
>=20
> BTW, nocona is not AMD CPU. However nocona is listed as `AMD CPUs' in sha=
re/examples/etc/make.conf.
Wasn't that already fixed?
> >How-To-Repeat:
>=20
> >Fix:
> --- Makefile.inc1.orig Thu Jun 9 23:30:41 2005
> +++ Makefile.inc1 Thu Jun 9 23:35:26 2005
> @@ -205,7 +205,13 @@
> # 32 bit world
> LIB32TMP=3D ${OBJTREE}${.CURDIR}/lib32
>=20
> -LIB32PREFLAGS=3D -m32 -march=3Dathlon-xp -msse2 -mfancy-math-387 -DCOMPA=
T_32BIT
> +LIB32PREFLAGS=3D -m32 -msse2 -mfancy-math-387 -DCOMPAT_32BIT
> +.if ${TARGET_CPUTYPE} =3D=3D "nocona"
> +LIB32PREFLAGS+=3D -march=3Dprescott
> +.else
> +LIB32PREFLAGS+=3D -march=3Dathlon-xp
> +.endif
This should probably go into bsd.cpu.mk somehow to avoid scattering
-march logic elsewhere in the system.
Kris
--AhhlLboLdkugWU4S
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQFCqHv+Wry0BWjoQKURAibMAKDE6jzQuDdeCfsppA/5Hr7f33nYZgCg3IxX
AHBWQrCtFEbInX6QDx1jwnA=
=XqZi
-----END PGP SIGNATURE-----
--AhhlLboLdkugWU4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506091730.j59HUF5x026589>