From nobody Thu Apr 16 22:21:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxXYc3ldWz6Zmv0; Thu, 16 Apr 2026 22:21:56 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxXYc3BrJz3NYV; Thu, 16 Apr 2026 22:21:56 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776378116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ryKnZkq9cYP5sjNTLZtKzNwxbFy8Z62kkdqPys4LR4c=; b=HEpG0vTuIMmnyBv+ickiHR0qHbZdXRranpnbTTicxM4z74+1UQ4e2o+hsAfiTNl/7dKft+ /WbOXdxVmzV3Yu4iCyWgBD7/EzjszAlI5NzcbwVi8lWSyzpdz/wvlZQB2BxYfWjQdS6B7t N42nDBtrwAWcYonstdZYqp9k5UIak6BEXswzbyPZIaVh/K0AZMZXKvErrDukz7nxCUoGY+ zKWVT57Q3QUKnt/iWcL18Gsy/3EHxyevdz+ieCKXFfG1ql+gCGUFrl7LdB9dApaAiHWTVd B3UX+7lwmK8UbTF9kErPkUsHk+PR/TbswEV0zyNfbhy0Y7ia62XLzixTIytn7w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776378116; a=rsa-sha256; cv=none; b=PDd9r7f9QAyKzSdwR6jfGILuwHeWBCN2fCiR7QsqwA7zCRkT54/OVizZKhLEKQHwX/qrq5 49W3Hg71tMIrGfBiznPOQzqNwzKkNmCaID6Nd8DI9AwDBGXMjMO/7YQMLZp+FBJanZB5x9 /mFPu6XxUaWq5ds+FklXuIW+5kknOf8n/25H1+vAm/3u/v0dwij58RnmmATr+jnmiCaBbr TOWQbwC6PCx5lrFBILuYALJAigPhxCEbIKWSQPW/aLEDt6ocIHXMUVuG//Q9g9IALoHO1n pWE2mdmw8UUlewaU8DzWErJJc2ZUM4Cn9QCqcb6a1tntiinKDtf11GpyRuu2Bg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776378116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ryKnZkq9cYP5sjNTLZtKzNwxbFy8Z62kkdqPys4LR4c=; b=v9PN33fZwP0WbzHKqjG9h4n4yfdgPFPidmnJYT2xXVrwwPXN+gczahEX6nTREztaCkBu/p sfxnpVy16nN5cUVe911irMBBLE++wL/rYCIn/x37iqBXj7qxKANHQicRLliVvEJMg3OZyx HKoQWiS2LkfDb+L2iIulKKYPlesA3Zoj304l5rSIsqF6wB2X3Y40Ysp2hVH1IepDY/q7RW vuu2uxs9wqJsFmajTKKqNLnfAZIS2uk9y3GKV/Xdf/j45ZMfoVAd82HPB0kOeUvwc5Ga1c fwj1SavpJtR6hF8iGok05pY8tTWy8I+roGtUpj46GasM1zhEU/Q7x2wG70sBbA== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R12" (not verified)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fxXYc1r41zJ4q; Thu, 16 Apr 2026 22:21:56 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 484DA1F027; Fri, 17 Apr 2026 00:21:53 +0200 (CEST) From: Kristof Provost To: Pouria Mousavizadeh Tehrani Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 688e289ee904 - main - ifconfig: Add support for geneve (netlink) Date: Fri, 17 Apr 2026 00:21:51 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: In-Reply-To: <69dcfad9.46b23.7e93103@gitrepo.freebsd.org> References: <69dcfad9.46b23.7e93103@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_63B2A02B-69AA-45C6-8232-929A7F889685_=" --=_MailMate_63B2A02B-69AA-45C6-8232-929A7F889685_= Content-Type: text/plain; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 13 Apr 2026, at 16:16, Pouria Mousavizadeh Tehrani wrote: > The branch main has been updated by pouria: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D688e289ee904fe625d92f93680a71= 753d03ba2ee > > commit 688e289ee904fe625d92f93680a71753d03ba2ee > Author: Pouria Mousavizadeh Tehrani > AuthorDate: 2026-04-11 18:38:41 +0000 > Commit: Pouria Mousavizadeh Tehrani > CommitDate: 2026-04-13 14:15:01 +0000 > > ifconfig: Add support for geneve (netlink) > > This implementation is netlink only > > Differential Revision: https://reviews.freebsd.org/D55184 This fails to build if WITHOUT_NETLINK_SUPPORT=3Dyes is set. I think we need this: diff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile index cc518693c2f5..26391023d54a 100644 --- a/sbin/ifconfig/Makefile +++ b/sbin/ifconfig/Makefile @@ -30,7 +30,6 @@ SRCS+=3D ifmedia.c # = SIOC[GS]IFMEDIA support SRCS+=3D iffib.c # non-default FIB support SRCS+=3D ifvlan.c # SIOC[GS]ETVLAN support SRCS+=3D ifvxlan.c # VXLAN support -SRCS+=3D ifgeneve.c # GENEVE support SRCS+=3D ifgre.c # GRE keys etc SRCS+=3D ifgif.c # GIF reversed header workaround SRCS+=3D ifipsec.c # IPsec VTI @@ -67,6 +66,7 @@ LIBADD+=3D nv .if ${MK_NETLINK_SUPPORT} !=3D "no" SRCS+=3D ifconfig_netlink.c +SRCS+=3D ifgeneve.c # GENEVE support .else CFLAGS+=3D-DWITHOUT_NETLINK .endif Best regards, Kristof --=_MailMate_63B2A02B-69AA-45C6-8232-929A7F889685_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

On 13 Apr 2026, at 16:16, Pouria Mousavizadeh Tehrani wro= te:

The branch main has been updated by pouria:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D688e289ee904fe625d92f93680a71753d03ba2ee

commit 688e289ee904fe625d92f93680a71753d03ba2ee
Author: Pouria Mousavizadeh Tehrani pouria@FreeBSD.org
AuthorDate: 2026-04-11 18:38:41 +0000
Commit: Pouria Mousavizadeh Tehrani pouria@FreeBSD.org
CommitDate: 2026-04-13 14:15:01 +0000

if=
config: Add support for geneve (netlink)

This implementation is netlink only

Differential Revision: https://reviews.freebsd.org/D55184

This fails to build if WITHOUT_NETLINK_SUPPORT=3Dyes is s= et.

I think we need this:

di=
ff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile
index cc518693c2f5..26391023d54a 100644
--- a/sbin/ifconfig/Makefile
+++ b/sbin/ifconfig/Makefile
@@ -30,7 +30,6 @@ SRCS+=3D        ifmedia.c               # SIOC[GS]IFMED=
IA support
 SRCS+=3D iffib.c                 # non-default FIB support
 SRCS+=3D ifvlan.c                # SIOC[GS]ETVLAN support
 SRCS+=3D ifvxlan.c               # VXLAN support
-SRCS+=3D ifgeneve.c              # GENEVE support
 SRCS+=3D ifgre.c                 # GRE keys etc
 SRCS+=3D ifgif.c                 # GIF reversed header workaround
 SRCS+=3D ifipsec.c               # IPsec VTI
@@ -67,6 +66,7 @@ LIBADD+=3D      nv

 .if ${MK_NETLINK_SUPPORT} !=3D "no"
 SRCS+=3D ifconfig_netlink.c
+SRCS+=3D ifgeneve.c              # GENEVE support
 .else
 CFLAGS+=3D-DWITHOUT_NETLINK
 .endif

Best regards,
Kristof

--=_MailMate_63B2A02B-69AA-45C6-8232-929A7F889685_=--