From owner-svn-ports-all@freebsd.org Wed Jan 22 21:01:13 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E8B3F1FD4EE; Wed, 22 Jan 2020 21:01:13 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 482yVx5vZjz4Wyy; Wed, 22 Jan 2020 21:01:13 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 6907049CBA; Wed, 22 Jan 2020 22:01:04 +0100 (CET) Date: Wed, 22 Jan 2020 22:01:03 +0100 From: Piotr Kubaj To: Christoph Moench-Tegeder Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r523845 - head/www/chromium/files Message-ID: <20200122210103.GA67462@KGPE-D16> References: <202001222053.00MKrgIM068442@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <202001222053.00MKrgIM068442@repo.freebsd.org> X-Rspamd-Queue-Id: 482yVx5vZjz4Wyy X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.995,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jan 2020 21:01:14 -0000 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable www/iridium has the same problem, can you apply this patch there as well? On 20-01-22 20:53:42, Christoph Moench-Tegeder wrote: > Author: cmt > Date: Wed Jan 22 20:53:41 2020 > New Revision: 523845 > URL: https://svnweb.freebsd.org/changeset/ports/523845 >=20 > Log: > fix build > =20 > in a 12.1amd64 poudriere, chromium failed: > In file included from ../../third_party/leveldatabase/port/port_chromiu= m.cc:10: > ../../third_party/snappy/src/snappy.h:76:59: error: unknown type name '= string'; did you mean 'std::string'? > size_t Compress(const char* input, size_t input_length, string* outpu= t); > ^~~~~~ > std::string > /usr/include/c++/v1/iosfwd:211:65: note: 'std::string' declared here > =20 > instead of trying to muck around with type aliasing (see > snappy-stubs-public.h.in) just reference thy type directly, as there's = only > one file requiring patching. > =20 > MFH: 2020Q1 (blanket: web browser, just fix it) >=20 > Added: > head/www/chromium/files/patch-third__party_snappy_src_snappy.h (conte= nts, props changed) >=20 > Added: head/www/chromium/files/patch-third__party_snappy_src_snappy.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/www/chromium/files/patch-third__party_snappy_src_snappy.h Wed Ja= n 22 20:53:41 2020 (r523845) > @@ -0,0 +1,20 @@ > +--- third_party/snappy/src/snappy.h.orig 2020-01-22 18:43:16 UTC > ++++ third_party/snappy/src/snappy.h > +@@ -73,7 +73,7 @@ namespace snappy { > + // Original contents of *output are lost. > + // > + // REQUIRES: "input[]" is not an alias of "*output". > +- size_t Compress(const char* input, size_t input_length, string* outpu= t); > ++ size_t Compress(const char* input, size_t input_length, std::string* = output); > +=20 > + // Decompresses "compressed[0,compressed_length-1]" to "*uncompressed= ". > + // Original contents of "*uncompressed" are lost. > +@@ -82,7 +82,7 @@ namespace snappy { > + // > + // returns false if the message is corrupted and could not be decompr= essed > + bool Uncompress(const char* compressed, size_t compressed_length, > +- string* uncompressed); > ++ std::string* uncompressed); > +=20 > + // Decompresses "compressed" to "*uncompressed". > + // --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl4ouA8ACgkQelmbhSCD nJ06Hw//WqAVke2bRrvsc4GM7lN8MNWaFX/VlNXKOvVERpVuGo6MKB9mw+WYv3Nr M78XFquNB66y3vrC/RjjtT9Ny0aGYDplXCLCeowOO3rn7Cglz0hEwLdFF/VND81X cFuNAl1JD04RjN2hJvx6TZTLc4mqcVWN955qgCp4TEHUqS6ohgPGfdZJi0p5VqrY HJTfwo5n6AHxDNvz6egXDoO6mmye/Iwhskco4Y1bPe+Zq+4DP6ZuAW2Rfdneu0eW +ljcERt9YkdN069xR5NTE15TidXyG/Az25kB6Mi/3Z+ljyQpnEfrX76l4aQOwn/Q T3x6fWiX5Lev7XVQtYD4CfujrOZ9FwVKkNBKhKW33KPJAvOxszAshB6/Y+xNqL19 qUo7vZVTlhQ/ELWZtmaz2Ko8RDAlvpB4JIj8iaEBo6c2GHvSxsLlddB33swHOqfE 0XFqmFw+ETUEkupbm3dJBVswgi5lD2YJdY7utoMMaGWKMwAAfbB8hR3wkh//KTcE Mkxm10seXCoBmOeCNKZNYJfemzPkkvTXs0dX7+znbwNOiHf78MIq/88U8MEZBTjF 5f4tGw2TYK2DXjxInhiSRTkeHXE6PEOXBmTAtKQwNWJT/IuFeUsN5Pse1qjOZfB4 Yrj1Q+4m2U8+39r5Zo4l/TwmyUsR4Vea5MAo7noeSw7LLGxW0ro= =xopR -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--