Date: Sun, 9 Sep 2007 10:57:47 -0800 (AKDT) From: Mel <mel.xyzzy@rachie.is-a-geek.net> To: FreeBSD-gnats-submit@freebsd.org Cc: MAINTAINER <gnome@FreeBSD.org> Subject: [patch] Shoot yourself in the foot fix for firefox Message-ID: <20070909185747.895241CCD0@snoogles.rachie.is-a-geek.net>
next in thread | raw e-mail | index | archive | help
>Submitter-Id: current-users >Originator: Mel >Organization: >Confidential: no >Synopsis: [patch] Shoot yourself in the foot fix for firefox >Severity: non-critical >Priority: medium >Category: ports >Class: change-request >Release: FreeBSD 6.2-STABLE i386 >Environment: System: FreeBSD snoogles.rachie.is-a-geek.net 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Mar 26 09:16:30 AKDT 2007 root@smoochies.rachie.is-a-geek.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Ref: http://lists.freebsd.org/pipermail/freebsd-questions/2007-September/157558.html As a side-note: Since Xorg 7.2, ports linking with libX11/libXpm pull in a horde of dependencies frequently for little functionality. Good example: php[45]-gd: xpm support is hardly used in the real world(tm). So people set WITHOUT_X11 in /etc/make.conf and forget about it. Also, flags set with portupgrade's -m option live throughout build of ports' dependencies. >How-To-Repeat: Compile pango with WITHOUT_X11 somewhere defined. Then compile firefox. >Fix: Patch assumes WANT_GNOME verifies pango dependency but does not account for WITHOUT_X11 flag. --- Makefile.orig Sat Sep 8 02:46:36 2007 +++ Makefile Sun Sep 9 10:40:41 2007 @@ -24,6 +24,9 @@ MOZ_OPTIONS= --program-transform-name='s/firefox/${MOZILLA}/' WANT_GNOME= yes +.if exists(${LOCALBASE}/libdata/pango.pc) && ! exists(${LOCALBASE}/libdata/pangox.pc) +BROKEN= This port requires pango built with X11 support. Recompile pango making sure WITHOUT_X11 is undefined. +.endif ALL_TARGET= default CONFIGURE_ENV= LOCALBASE=${LOCALBASE} EXTRA_CFLAGS= -O2
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070909185747.895241CCD0>