From owner-freebsd-smp Mon Mar 18 10:43: 7 2002 Delivered-To: freebsd-smp@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id DAC6A37B417 for ; Mon, 18 Mar 2002 10:42:56 -0800 (PST) Received: (qmail 23647 invoked from network); 18 Mar 2002 18:42:55 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 18 Mar 2002 18:42:55 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2IIhOv53857; Mon, 18 Mar 2002 13:43:24 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020318183151.GA22622@elvis.mu.org> Date: Mon, 18 Mar 2002 13:42:58 -0500 (EST) From: John Baldwin To: Alfred Perlstein Subject: Re: -current lock warning... Cc: Munehiro Matsuda , tanimura@r.dl.itc.u-tokyo.ac.jp, phk@FreeBSD.ORG, hitmaster2k@yahoo.com, current@FreeBSD.ORG, smp@FreeBSD.ORG, Robert Watson Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 18-Mar-2002 Alfred Perlstein wrote: > * John Baldwin [020318 10:24] wrote: >> >> On 17-Mar-2002 Robert Watson wrote: >> > >> > On Sun, 17 Mar 2002, Alfred Perlstein wrote: >> > >> >> * Munehiro Matsuda [020317 06:36] wrote: >> >> > >> >> > PS. I got another message that happend when I ^C'ed a buildworld >> >> > earlier, >> >> > with same kernel. May be it should go to Alfred Perlstein? >> >> > >> >> > lock order reversal >> >> > 1st 0xc198eec0 pipe mutex @ ../../../kern/sys_pipe.c:779 >> >> > 2nd 0xc0367fe0 Giant @ ../../../i386/i386/trap.c:716 >> >> >> >> I think there's a place where the pipe can fault on an address while >> >> copying, I'll take a look at this. >> > >> > Are there any assertions that should be in place for copyin/copyout >> > requring fault handling? It sounds like somewhere we need to assert that >> > Giant is held... >> >> More correct is that probably no locks other than Giant should be held for >> copyin/copyout. > > s/probably/definetly. > > Can you please provide a "blessed" API for raising and lowering a > "can't block" count in the thread? This can be used in copyout, > copyin, and a bunch of vm and buffer ops to make sure we aren't calling > them with mutexes held. *sigh* I've never objected to it and even provided you with tips on how to implement it. What more do you want? I'm not really sure we need it though to be honest as the implicit checks done by witness will probably ensure this for us. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message