From owner-freebsd-mono@FreeBSD.ORG Sat Dec 6 18:16:41 2014 Return-Path: Delivered-To: mono@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C7707733 for ; Sat, 6 Dec 2014 18:16:41 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AF71BF3A for ; Sat, 6 Dec 2014 18:16:41 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sB6IGfEM015155 for ; Sat, 6 Dec 2014 18:16:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: mono@FreeBSD.org Subject: [Bug 194660] lang/mono Add mono/metadata/mono-route.c for non-Linux ParseRouteInfo_local Date: Sat, 06 Dec 2014 18:16:41 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: romain@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mono@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-mono@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Mono and C# applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Dec 2014 18:16:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194660 --- Comment #17 from Romain Tarti=C3=A8re --- (In reply to Ben Woods from comment #16) > Thanks for that. > So if my pull request is accepted upstream, and we incorporate the change > into the FreeBSD port using a PATCHFILES statement in the Makefile, I ass= ume > the Makefile.in will not be changed? Would we have to maintain the changes > to that as a separate patch file? Exactly, if possible, I prefer having reference to bug-fixes as PATCHFILES = but since this change is quite large and has an impact on the generated Makefile.in, a separate patch is preferred in this case (as you attached). As soon as upstream merges your changes, I'll commit that patch, but in case they have some more suggestions, I guess we would have benefits to wait for= a "final" version. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=