From owner-freebsd-stable@freebsd.org Tue Oct 6 18:46:34 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 565609B6E1F for ; Tue, 6 Oct 2015 18:46:34 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E95C8985 for ; Tue, 6 Oct 2015 18:46:33 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: by wicfx3 with SMTP id fx3so171989392wic.0 for ; Tue, 06 Oct 2015 11:46:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=WZAVmaU2RuKosy2hwvIWETMY7IAdm0vUJzwdf2reg7A=; b=RbzDflTLCt61DpCmMgpya49iheX+NORJo1NswvkibFnYzMPFA0xC2jpah26lYEcXKG /LpPJDzYb04iNHX3jRLxColkSCCp2hiYTAOPJSOjFt2toQt+o790zaS3hvQUp0KCsBUn FrFqTEcOXb14lY+BHBXFuD+3S/CIX7+f6YWkbXJJM0gWFk0749HB1ZS7VG0S3na2UVbi DljCXcwi7X7x3bcQBAqWEAEelOTglYfT767kyCgw5hdLSMjh1KovenHMocfxTUhxLm3g MEj4YmK2hKDfdrxFMgp8PvkgTZp/mj/t6TOw00wM0KtStOshY3FzwLUKyHlw+mgq6lQO oEhA== X-Gm-Message-State: ALoCoQnGflROUGcLUT+vev1GyK9Rc52km8YduCA8RW+wJ9mykVRUfWIGFoh28T5FoZZvnZVmwjOb X-Received: by 10.194.184.20 with SMTP id eq20mr8996251wjc.22.1444157186056; Tue, 06 Oct 2015 11:46:26 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id jj8sm20963674wid.2.2015.10.06.11.46.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Oct 2015 11:46:24 -0700 (PDT) Subject: Re: Dell NVMe issues To: Jim Harris , Sean Kelly References: <5613FA02.2080205@multiplay.co.uk> Cc: FreeBSD-STABLE Mailing List From: Steven Hartland Message-ID: <561416FB.1050802@multiplay.co.uk> Date: Tue, 6 Oct 2015 19:46:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 18:46:34 -0000 On 06/10/2015 19:03, Jim Harris wrote: > > > On Tue, Oct 6, 2015 at 9:42 AM, Steven Hartland > > wrote: > > Also looks like nvme exposes a timeout_period sysctl you could try > increasing that as it could be too small for a full disk TRIM. > > > Under CAM SCSI da support we have a delete_max which limits the > max single request size for a delete it may be we need something > similar for nvme as well to prevent this as it should still be > chunking the deletes to ensure this sort of thing doesn't happen. > > > See attached. Sean - can you try this patch with TRIM re-enabled in ZFS? > > I would be curious if TRIM passes without this patch if you increase > the timeout_period as suggested. > > -Jim > > Interesting does the nvme spec not provide information from the device as to what its optimal / max deallocate request size should be like the ATA spec exposes? Regards Steve