From nobody Tue Apr 7 01:31:12 2026 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fqTDv3nmyz6YQCq for ; Tue, 07 Apr 2026 01:31:27 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fqTDt1qDlz3H4L for ; Tue, 07 Apr 2026 01:31:26 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20240605:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of adrian.chadd@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=adrian.chadd@gmail.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-50b392f1846so65352141cf.3 for ; Mon, 06 Apr 2026 18:31:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775525484; cv=none; d=google.com; s=arc-20240605; b=cwBhMf+2MZqXFmtiTx/8Mi3eMrrJWdGuP8eC6soudP6MUg9TrYWCvS3676XFZbxQUC 32GoFsb8ni8XRUeHmz6a33MVt+4m3/xEGYtL4KXMNjUm324v3r9/+CbpQQcPaOnCCj6P ySLtYUoi9FJPPpzVdHHF1lvKBfCQuGUwhgwQUPcGe5qck3F9WIhEGbda70cvAXe3tjo8 ojSitGtjk7Oq9jxlPL34GNX1tvb1rDjOCTzJCO3N/YGUHvK9QSX2llHiJXUh8CNBEdHF XqMG+fK0Fz19yRnaLWiV/+1mSAYtKNFzPyy06Jl4TO18F9zf/fVzaqZCeDcjIYZQOngx Wtkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:from:in-reply-to:references:mime-version; bh=TyCWI1FjrC7L/bbCL9Hq2ezU/Zv144gy+Zwlh5D6hug=; fh=odXGQpnPMRlnAmVyqNXihH0IL4sf3hqBwVFzN+V8esE=; b=XXgpPbDvtlR4HTSBbSMWwgk4RPc8jAk8fbdoHIClHlmnR++YkCqb+K/WCSK41nQfuo jLlEMvryj4434N3qnzUjJR7YWzd86eY1y4G291xRr0+GHN99HWsH5r8z1vpBcD9RaibO ityX+m8Ut+nO3dm2ZoU5r1Ubwjw9APku9BCYDe+3WIIeV2vfookn1OW1JRp3gY3dN0B7 3HkGWvMO6oWXudtUgtbiB87sT1rRDeXfJqyEGPxspMPUMfvEL0I10TOT3YMBCTsvhhMs P+5z6ApiaK+LKMBf/fJ+m7xbPS0HzR1PHiQHyNy8iGB8W4I8YvbsCXhKfaZ6zv8FrI8s xFzA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775525484; x=1776130284; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TyCWI1FjrC7L/bbCL9Hq2ezU/Zv144gy+Zwlh5D6hug=; b=MlGTyaXOaq48RtseaBiOsUERClweww3/cNnJwL+aQwaNR491nnQ3XrykoO89bJ2b83 wH7xcmMY6Bu6Ym+ReXPIP0PGc72oci9h/HE5SOAMMpJCWAJ0vmur1t29CBehnnt59Hq8 jH5+dGvbyI85zp4IhGBAjHqaL3qw67qhmme9HK0wzbK64CkM8xZeqcUutxDhEej5rdj7 WySWyFZPnaH5qHx1Gzxox4VvlsNorrp52N//+HaGh5/x91Lr2c8qXUYnNdwVm3PozcYE mOQfXOP84lv6+Nml7SQLGRn1jKc2nwkYudci4UcPXERRO8Fka2eJrQq6YTYGisAmufMW gE8w== X-Gm-Message-State: AOJu0YxWr/ogubLVEwkwUlT6sgBXJCFahwZsX2rUjioRSIk+n1DCDdq2 qJOc6VQpLlXUnTVQKEq/PHF0A5Hn95/CspmdyRQ/KMwFbqOO9UXjVcOrM4ipR75gTV8VbIcwmkh GH4xoowBB7qnd2bYqTMtFRMcZktiwKz3hjw== X-Gm-Gg: AeBDieudzWRzE81e5HtaAMv7h8WEhnYtZeHgnNyIoK8hVS3+xC5mxna/JxS4/DtTZIY XHqQg4RDuYKzQvTVKFGkQke0KJaicVIWq/Rt9enHhj8HEUiNNiLFrLYB4+PMYSt+7iguNjKbWbP yyCbyH3+mcYstNDQE1mAdja1KFWx1MoJ1a1kh0eB7u+2aQVyaAzHsR25PW9Fwu/lKN/JZkC3mCk b4oc/OYpQu+lJKrEIXFdCgg+G95FV9ACiLIIQFhT3y2rbZ9Havcmwpj3cAW0tOmNg70CL74cSPq g0ucxYlq5qGGX77g99Jf1wzSKFM8B4E1AMh8wqeyh+oSQH2d/VXY7srVzIsnA3KJSd8QtHnrOvy 1SXcrlKJCSGO9+8bF3QTI7Mkx7dU= X-Received: by 2002:a05:622a:10d:b0:50b:4a3f:c798 with SMTP id d75a77b69052e-50d62a91b69mr224131441cf.43.1775525484013; Mon, 06 Apr 2026 18:31:24 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Mon, 6 Apr 2026 18:31:12 -0700 X-Gm-Features: AQROBzBUYnlHLAANwv1nK0_wHddMWeuV-G5qKDlQYRhNvtFupUEs4uNdNU8aZ-s Message-ID: Subject: Re: pkgbase breakage in main due to libucl upgrade To: current@freebsd.org, pkgbase@freebsd.org, bofh@freebsd.org, bapt@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-1.54 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_SPAM_MEDIUM(0.92)[0.919]; NEURAL_HAM_LONG(-0.87)[-0.873]; NEURAL_HAM_SHORT(-0.69)[-0.688]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.160.175:from]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; TAGGED_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.160.175:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; TO_DN_NONE(0.00)[]; MLMMJ_DEST(0.00)[current@freebsd.org]; RCPT_COUNT_THREE(0.00)[4]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4fqTDt1qDlz3H4L X-Spamd-Bar: - hi! On Mon, 6 Apr 2026 at 07:11, Lexi Winter wrote: > > hello, > > as a couple of people already reported[0][1] the pkgbase build is > currently broken in main. this affects building packages for any > version of FreeBSD when the build host is main abda442d92fd[2] or > later. > > this is not trivial to fix. the issue is that libucl changed the > lua bindings in an incompatible way, specifically to disable use > of macros (which includes ".include") by default[3]. that breaks > the API that the pkgbase build scripts rely on, and those scripts > use the host flua. > > as an immediate fix, i have three diffs for review: > > - "packages: Fix build with libucl 0.9.3" > https://reviews.freebsd.org/D56266 > > this change, which is backward-compatible with previous versions > of lua libucl, fixes the ABI breakage. > > - "flua: Always build as a bootstrap tool" > https://reviews.freebsd.org/D56270 > "packages: Always use the bootstrap flua" > https://reviews.freebsd.org/D56271 > > these changes mean we'll use the version of flua and libucl from > the source tree to build packages, instead of the host versions, > which protects us from future API breaks. > > if you're running into this issue right now, you can apply the patch > from D56266 to fix your build, and optionally the other two diffs if > you like (but they aren't required). this has to be done on the src > tree being built, *not* the build system. > > unfortunately, none of these changes fix the general problem which is > that we can't build FreeBSD 15.0 on FreeBSD 16-CURRENT. i'm open to > other suggestsions here, but i think the best approach is to revert the > libucl commit that changed the ABI; while this is a security fix, the > only things using flua are in the base system, and none of them should > be affected by the issue being fixed. > > any thoughts? > > [0] https://lists.freebsd.org/archives/freebsd-current/2026-April/010080.html > [1] https://lists.freebsd.org/archives/freebsd-pkgbase/2026-April/001284.html > [2] https://cgit.freebsd.org/src/commit/?id=abda442d92fdbadcf81c79bc9ddba001d133c429 > [3] https://github.com/vstakhov/libucl/commit/8a0294f9eaa4e70342e562cb92792bbe3df90e70 *reads* * I think your diffs / approach is good; * I honestly don't think we should revert the libucl change; it'll just end up making future work less fun as other random flua/libucl shenanigans happen; * I think we should document in the 15.0 errata that building 15.0 on 16.0 after date X is a known broken thing, and to either build on 15.x or apply a workaround (eg a patch to disable the check, explaining what it does and the security risk) * and I think we should figure out what to backport to stable/15 to unbreak things. -adrian