From owner-freebsd-net@FreeBSD.ORG  Thu May  3 01:50:15 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B166106564A
	for <freebsd-net@hub.freebsd.org>; Thu,  3 May 2012 01:50:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 568118FC0A
	for <freebsd-net@hub.freebsd.org>; Thu,  3 May 2012 01:50:15 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q431oFdL041081
	for <freebsd-net@freefall.freebsd.org>; Thu, 3 May 2012 01:50:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q431oFdd041080;
	Thu, 3 May 2012 01:50:15 GMT (envelope-from gnats)
Date: Thu, 3 May 2012 01:50:15 GMT
Message-Id: <201205030150.q431oFdd041080@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/138620: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2012 01:50:15 -0000

The following reply was made to PR kern/138620; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138620: commit references a PR
Date: Thu,  3 May 2012 01:41:22 +0000 (UTC)

 Author: emaste
 Date: Thu May  3 01:41:12 2012
 New Revision: 234936
 URL: http://svn.freebsd.org/changeset/base/234936
 
 Log:
   Relax restriction on direct tx to child ports
   
   Lagg(4) restricts the type of packet that may be sent directly to a child
   port, to avoid undesired output from accidental misconfiguration.
   Previously only ETHERTYPE_PAE was permitted.
   
   BPF writes to a lagg(4) child port are presumably intentional, so just
   allow them, while still blocking other packets that should take the
   aggregation path.
   
   PR:		kern/138620
   Approved by:	thompsa@
 
 Modified:
   head/sys/net/if_lagg.c
 
 Modified: head/sys/net/if_lagg.c
 ==============================================================================
 --- head/sys/net/if_lagg.c	Wed May  2 21:50:13 2012	(r234935)
 +++ head/sys/net/if_lagg.c	Thu May  3 01:41:12 2012	(r234936)
 @@ -764,28 +764,18 @@ fallback:
  	return (EINVAL);
  }
  
 +/*
 + * For direct output to child ports.
 + */
  static int
  lagg_port_output(struct ifnet *ifp, struct mbuf *m,
  	struct sockaddr *dst, struct route *ro)
  {
  	struct lagg_port *lp = ifp->if_lagg;
 -	struct ether_header *eh;
 -	short type = 0;
  
  	switch (dst->sa_family) {
  		case pseudo_AF_HDRCMPLT:
  		case AF_UNSPEC:
 -			eh = (struct ether_header *)dst->sa_data;
 -			type = eh->ether_type;
 -			break;
 -	}
 -
 -	/*
 -	 * Only allow ethernet types required to initiate or maintain the link,
 -	 * aggregated frames take a different path.
 -	 */
 -	switch (ntohs(type)) {
 -		case ETHERTYPE_PAE:	/* EAPOL PAE/802.1x */
  			return ((*lp->lp_output)(ifp, m, dst, ro));
  	}
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"