From owner-svn-src-all@FreeBSD.ORG Thu Jul 4 20:40:49 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 40A8FD4E; Thu, 4 Jul 2013 20:40:49 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 08FC11DC2; Thu, 4 Jul 2013 20:40:48 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id B6CECF07; Thu, 4 Jul 2013 22:36:04 +0200 (CEST) Date: Thu, 4 Jul 2013 22:41:12 +0200 From: Pawel Jakub Dawidek To: "Pedro F. Giffuni" Subject: Re: svn commit: r252435 - in head/sys/ufs: ffs ufs Message-ID: <20130704204112.GC1402@garage.freebsd.pl> References: <201307010300.r6130GWT035496@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q9KOos5vDmpwPx9o" Content-Disposition: inline In-Reply-To: <201307010300.r6130GWT035496@svn.freebsd.org> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2013 20:40:49 -0000 --q9KOos5vDmpwPx9o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 01, 2013 at 03:00:16AM +0000, Pedro F. Giffuni wrote: > Author: pfg > Date: Mon Jul 1 03:00:15 2013 > New Revision: 252435 > URL: http://svnweb.freebsd.org/changeset/base/252435 >=20 > Log: > Change i_gen in UFS to an unsigned type. > =20 > In UFS, i_gen is a random generated value and there is not way for > it to be negative. Actually, the value of i_gen is just used to > match bit patterns and it is of not consequence if the values are > signed or not. > =20 > Following other filesystems, set it to unsigned and use it as such, > =20 > Discussed by: mckusick > Reviewed by: mckusick (previous version) > MFC after: 4 weeks [...] > printf("ufs_extattr_get (%s): inode number inconsistency (%d, %jd)\n", > - mp->mnt_stat.f_mntonname, ueh.ueh_i_gen, (intmax_t)ip->i_gen); > + mp->mnt_stat.f_mntonname, ueh.ueh_i_gen, (uintmax_t)ip->i_gen); For uintmax_t you also need to change %jd to %ju. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --q9KOos5vDmpwPx9o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iEYEARECAAYFAlHV3egACgkQForvXbEpPzRYMQCfZmA25OrItS3NSYXcgxvcm/9A EnwAoJZmG8gYdirggMhTxjVEPSdDuPLi =5qT9 -----END PGP SIGNATURE----- --q9KOos5vDmpwPx9o--