From owner-freebsd-doc@FreeBSD.ORG Fri Apr 12 00:02:24 2013 Return-Path: Delivered-To: freebsd-doc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 80F08CA7 for ; Fri, 12 Apr 2013 00:02:24 +0000 (UTC) (envelope-from wblock@wonkity.com) Received: from wonkity.com (wonkity.com [67.158.26.137]) by mx1.freebsd.org (Postfix) with ESMTP id 404482DB for ; Fri, 12 Apr 2013 00:02:23 +0000 (UTC) Received: from wonkity.com (localhost [127.0.0.1]) by wonkity.com (8.14.6/8.14.6) with ESMTP id r3C02Mrg086419; Thu, 11 Apr 2013 18:02:22 -0600 (MDT) (envelope-from wblock@wonkity.com) Received: from localhost (wblock@localhost) by wonkity.com (8.14.6/8.14.6/Submit) with ESMTP id r3C02MYV086416; Thu, 11 Apr 2013 18:02:22 -0600 (MDT) (envelope-from wblock@wonkity.com) Date: Thu, 11 Apr 2013 18:02:22 -0600 (MDT) From: Warren Block To: Taras Korenko Subject: Re: [patch] en/handbook/ports: another small cleanup In-Reply-To: <20130411173811.GD62384@chaos.ukrhub.net> Message-ID: References: <20130411173811.GD62384@chaos.ukrhub.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (wonkity.com [127.0.0.1]); Thu, 11 Apr 2013 18:02:23 -0600 (MDT) Cc: freebsd-doc@FreeBSD.org X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2013 00:02:24 -0000 On Thu, 11 Apr 2013, Taras Korenko wrote: > Hi, folks. > > Could anyone of doc@ review/comment/approve the following small changes > to en/books/handbook/ports ? > > > 1) An obvious chunk: > ---------------------------------------------------------------------------- > Index: en_US.ISO8859-1/books/handbook/ports/chapter.xml > =================================================================== > --- en_US.ISO8859-1/books/handbook/ports/chapter.xml (revision 41406) > +++ en_US.ISO8859-1/books/handbook/ports/chapter.xml (working copy) > @@ -116,7 +116,7 @@ > commands. > > Both packages and ports understand > - dependencies. If &man.pkg.add.1; or the > + dependencies. If &man.pkg.add.1; or the > Ports Collection is used to install an application and a > dependent library is not already installed, the library will > automatically be installed first. > @@ -1337,7 +1337,7 @@ > > Once the compile is complete, you are returned to the > prompt. The next step is to install the port using > - make install: > + make install: Agreed on the command tags, but I'm not sure the maketarget tags are needed there. Can't say they should not be there either, though. > &prompt.root; make install > ===> Installing for lsof-4.57 > @@ -1670,22 +1670,22 @@ > > > Root ports: no dependencies and is not depended on > - by other ports > + by other ports; > > > > Trunk ports: no dependencies, but other ports depend > - upon it > + upon it; > > > > Branch ports: have dependencies and are depended > - upon by other ports > + upon by other ports; > > > > Leaf ports: have dependencies but are not depended > - upon by other ports > + upon by other ports. > > Adding those semicolons and the period makes those entries into a long sentence, or tries. But they are already in a list, so this seems unnecessary. Besides, semicolons are kind of weakly evil. Using them as a supercomma is not so bad, but still... Also, they may have to be entered as ;. Or maybe not, I've lost track. > ---------------------------------------------------------------------------- > > > 2) A controversial one: > ---------------------------------------------------------------------------- > Index: en_US.ISO8859-1/books/handbook/ports/chapter.xml > =================================================================== > --- en_US.ISO8859-1/books/handbook/ports/chapter.xml (revision 41406) > +++ en_US.ISO8859-1/books/handbook/ports/chapter.xml (working copy) > @@ -1778,7 +1778,8 @@ > > > The portsclean utility is part of the > - portupgrade suite. > + ports-mgmt/portupgrade > + suite. > Seems okay to me.