From owner-p4-projects@FreeBSD.ORG  Wed Dec 14 02:33:20 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F185816A422; Wed, 14 Dec 2005 02:33:19 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 91FA116A41F
	for <perforce@freebsd.org>; Wed, 14 Dec 2005 02:33:19 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 26EE743D58
	for <perforce@freebsd.org>; Wed, 14 Dec 2005 02:33:19 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jBE2Vm47024700;
	Tue, 13 Dec 2005 19:31:52 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 13 Dec 2005 19:31:48 -0700 (MST)
Message-Id: <20051213.193148.74726062.imp@bsdimp.com>
To: marcel@xcllnt.net
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <3D3166CC-DBC3-45C1-B78B-5CFE5F57C580@xcllnt.net>
References: <200512122158.jBCLwwCt085740@repoman.freebsd.org>
	<3D3166CC-DBC3-45C1-B78B-5CFE5F57C580@xcllnt.net>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Tue, 13 Dec 2005 19:31:53 -0700 (MST)
Cc: perforce@freebsd.org
Subject: uart change
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2005 02:33:20 -0000

From: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: PERFORCE change 88102 for review
Date: Mon, 12 Dec 2005 16:45:32 -0800

> 
> On Dec 12, 2005, at 9:58 PM, Warner Losh wrote:
> 
> > http://perforce.freebsd.org/chv.cgi?CH=88102
> >
> > Change 88102 by imp@imp_Speedy on 2005/12/12 21:58:35
> >
> > 	Make uart_subr not depend on ns8250.o
> 
> This is not such a good change. As the comment says in uart_subr.c, it's
> just a default. There's nothing PC specific about it. It's the the most
> common case and therefore a sensible default.
> 
> Now, if it makes sense to have MD specific defaults and not MI defaults,
> then it makes sense to have ALL the defaults set in MD code and none in
> MI code (or if they are set in MI code, they should be set before MD
> defaults can be set to override the MI defaults).
> 
> What really needs to be done is add support for the DT tag, so that you
> can set the device type in the environment....

This is a good change.

The problem is that it forces you to link in uart_dev_ns8250.o, even
if your platform doesn't have one of those.  That's the reason that I
moved it out of there.  It has nothing to do with what the default
device should be, but rather the linkage dependency it creates

Warner