From owner-cvs-all@FreeBSD.ORG Fri Jun 25 12:21:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FE0316A4DE; Fri, 25 Jun 2004 12:21:49 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3557C43D5C; Fri, 25 Jun 2004 12:21:48 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i5PCRhMx076725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Jun 2004 15:27:45 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i5PCLqDu046942; Fri, 25 Jun 2004 15:21:52 +0300 (EEST) (envelope-from ru) Date: Fri, 25 Jun 2004 15:21:47 +0300 From: Ruslan Ermilov To: Dag-Erling Sm?rgrav Message-ID: <20040625122147.GA38746@ip.net.ua> References: <200406250154.i5P1sQcp072094@repoman.freebsd.org> <20040625120329.GB37003@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: Alexander Kabaev cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2004 12:21:49 -0000 --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote: > Ruslan Ermilov writes: > > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote: > > > Alexander Kabaev writes: > > > > Log: > > > > Remove the use of cast as lvalue. > > > This trades one style bug for another (missing space before *), breaks > > > the build on 64-bit platforms, and violates maintainership. > > Ah, so this commit is responsible for a cross-build breakage... >=20 > No, this one currently only breaks Alpha because we apparently don't > enforce alignment requirements on other platforms. >=20 It also breaks ia64 (verified on pluto1), and probably sparc64 too (my cross-build test broke). I restarted my sparc64 cross-build test with the following bandaid patch for the time being: %%% Index: pam_radius.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/lib/libpam/modules/pam_radius/pam_radius.c,v retrieving revision 1.21 diff -u -p -r1.21 pam_radius.c --- pam_radius.c 25 Jun 2004 01:54:26 -0000 1.21 +++ pam_radius.c 25 Jun 2004 12:18:16 -0000 @@ -111,7 +111,7 @@ build_access_request(struct rad_handle * hints.ai_family =3D PF_INET; if (getaddrinfo(nas_ipaddr, NULL, &hints, &res) =3D=3D 0 && res !=3D NULL) { - haddr =3D (struct sockaddr_in*)res->ai_addr; + haddr =3D (struct sockaddr_in *)(void *)res->ai_addr; error =3D rad_put_addr(radh, RAD_NAS_IP_ADDRESS, haddr->sin_addr); freeaddrinfo(res); %%% Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA3BjbqRfpzJluFF4RAhLaAJ9nY6FQzcQiWWvQn9oJtVVzYbluKgCgisdf nXn87xTA3a+fHOlj9N1dzzo= =NXK+ -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF--