From owner-cvs-all  Sat Mar 16  8:18: 7 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6515437B425; Sat, 16 Mar 2002 08:06:02 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id DAA08515;
	Sun, 17 Mar 2002 03:05:53 +1100
Date: Sun, 17 Mar 2002 03:07:29 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Bernd Walter <ticso@cicely8.cicely.de>
Cc: John Hay <jhay@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>, "Herbert J. Skuhra" <herbert@bugat.at>
Subject: Re: cvs commit: src/sys/dev/sio sio.c sio_isa.c sio_pccard.c sio_pci.c
 sioreg.h siovar.h
In-Reply-To: <20020316144628.GA1170@cicely8.cicely.de>
Message-ID: <20020317030440.V33393-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 16 Mar 2002, Bernd Walter wrote:

> On Wed, Jan 30, 2002 at 09:22:04AM -0800, John Hay wrote:
> > jhay        2002/01/30 09:22:04 PST
> >
> >   Modified files:
> >     sys/dev/sio          sio.c sio_isa.c sio_pccard.c sio_pci.c
> >                          sioreg.h siovar.h
> >   Log:
> >   Add support for different serial clock frequencies and not just the
> >   standard one of 1.8432MHz. This will be used by the puc (PCI
> >   "universal" communication card) device driver.
>
> This commit breaks my seriel console.
> I get a console speed of 1355bps after that.
> loader worked fine with 9600bps.
> It seems that siocngetspeed read bogus values from my sio.
> Now that the sanity checks are removed the value gets used.
> Another one on a german list has the same problem with 4.5-stable
> and a different board/cpu.

How do you select booting with a serial console?  The boot program is
supposed be using the serial console (if it sets RB_SERIAL at all),
and if the device doesn't have read/write registers then other things
will break.  0x55 looks like garbage from a probe.

> And the remark section for the function claims to return 0 in some
> cases which is obsolete now.

Also, the check for 0 in the caller is bogus at best.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message