Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Jan 2020 12:42:38 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 242756] [NEW PORT] devel/py-pytest-pep8: Pytest plugin for efficiently checking PEP8 compliance
Message-ID:  <bug-242756-21822-q5pXjBWgJv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-242756-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-242756-21822@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242756

--- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> ---
Review items:

1) USES=python:<version-spec> is incorrect. 3.5+ incorrectly limits version
support to >= 3.5 ...

Upstream declares support for 2.6,2.7,3.3,3.4. 

USES=python:<version-spec> should match this as closely as possible without
being incorrect, modulo any syntax limitations in <version-spec> (doesn't
support !=, etc). 

USES=python is the most correct in this case.

However, if a package doesn't declare support for certain versions, but they
are allowed by <version-spec>, port maintainer should QA (test suite)
extensively with those undeclared versions to ensure they work, otherwise limit
the versions accordingly. In this case, this means explicit QA/test suite
testing for 3.5+

2) package dependencies declare versions [1], *_DEPENDS should match these as
closely as possible

[1]  install_requires=['pytest-cache', 'pytest>=2.4.2', 'pep8>=1.3', ],

-- 
You are receiving this mail because:
You are on the CC list for the bug.

help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242756-21822-q5pXjBWgJv>