From owner-svn-src-all@freebsd.org Thu Aug 25 20:14:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE2C5BC4098; Thu, 25 Aug 2016 20:14:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9ED1F13D0; Thu, 25 Aug 2016 20:14:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6C53FB923; Thu, 25 Aug 2016 16:14:55 -0400 (EDT) From: John Baldwin To: Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304815 - in head: lib lib/libifc share/examples/libifc share/mk Date: Thu, 25 Aug 2016 13:14:51 -0700 Message-ID: <23395083.lPEyYQ7ZbW@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201608251940.u7PJePv3023083@repo.freebsd.org> References: <201608251940.u7PJePv3023083@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 25 Aug 2016 16:14:55 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 20:14:56 -0000 On Thursday, August 25, 2016 07:40:25 PM Kristof Provost wrote: > Author: kp > Date: Thu Aug 25 19:40:25 2016 > New Revision: 304815 > URL: https://svnweb.freebsd.org/changeset/base/304815 > > Log: > Add libifc, a library implementing core functionality that exists in ifconfig(8) today. > > libifc (pronounced lib-ifconfig) aims to be a light abstraction layer between > programs and the kernel APIs for managing the network configuration. > This should hopefully make programs easier to maintain, and reduce code > duplication. > > Work will begin on making ifconfig(8) use this library in the near future. > > This code is still evolving. The interface should not be considered stable until > it is announced as such. I hate even writing this mail, and it looks like the topic wasn't really discussed in the review, but I think libifconfig is probably the "better" name if the goal is to move most of ifconfig into it. Certainly if a developer is looking for a library that provides a programmatic interface to the same operations a user does via ifconfig, libifconfig is the name they will look for first. One thing I did see in the review is that the APIs use 'ifc_*' and that was the reason given for renaming the library. If you really want those to be in sync, I actually think the longer 'ifconfig_*' prefix isn't that terrible. We have other libraries that use similar length names and namespace prefixes already (libarchive, libdevctl, libdevinfo, libpthread). Hmm, it seems you are 'libifc_*'. Most of our libraries do not include 'lib' in the namespace prefix (see above examples that all use the name of the library without 'lib' as the prefix). If nothing else I'd suggest dropping 'lib' to be consistent with most other libraries in the tree. -- John Baldwin