From owner-p4-projects Thu Oct 10 7:58: 9 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3039D37B410; Thu, 10 Oct 2002 07:58:03 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A83E137B41D for ; Thu, 10 Oct 2002 07:58:02 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0328C440B8 for ; Thu, 10 Oct 2002 07:50:09 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 19959 invoked from network); 10 Oct 2002 14:49:46 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 10 Oct 2002 14:49:46 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9AEnbn5014822; Thu, 10 Oct 2002 10:49:38 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200210101415.g9AEF3bU083895@repoman.freebsd.org> Date: Thu, 10 Oct 2002 10:49:41 -0400 (EDT) From: John Baldwin To: Chris Vance Subject: RE: PERFORCE change 19023 for review Cc: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 10-Oct-2002 Chris Vance wrote: > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > Fix bug. I don't know if the style below is some NAI thing, but if you were using style(9), then the second lines would be at fixed offsets and wouldn't have to change. This would result in a smaller, easier-to-read diff that more obviously points out that you just added a single !. Just something to think about. There are a lot of pratical things behind style(9). > Affected files ... > > .. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 edit > > Differences ... > > ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 (text+ko) ==== > > @@ -496,9 +496,9 @@ > struct vnode *vp = a->u.fs.vp; > struct vattr va; > if (VOP_ISLOCKED(vp, curthread) && > - VOP_GETATTR(vp, &va, > - curthread->td_ucred, > - curthread)) { > + !VOP_GETATTR(vp, &va, > + curthread->td_ucred, > + curthread)) { > printf(" inode=%ld, fsid=%d, ftype=%d", > va.va_fileid, va.va_fsid, > vp->v_type); -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message