Date: Thu, 10 Oct 2002 10:49:41 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Chris Vance <cvance@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 19023 for review Message-ID: <XFMail.20021010104941.jhb@FreeBSD.org> In-Reply-To: <200210101415.g9AEF3bU083895@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10-Oct-2002 Chris Vance wrote: > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > Fix bug. I don't know if the style below is some NAI thing, but if you were using style(9), then the second lines would be at fixed offsets and wouldn't have to change. This would result in a smaller, easier-to-read diff that more obviously points out that you just added a single !. Just something to think about. There are a lot of pratical things behind style(9). > Affected files ... > > .. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 edit > > Differences ... > > ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 (text+ko) ==== > > @@ -496,9 +496,9 @@ > struct vnode *vp = a->u.fs.vp; > struct vattr va; > if (VOP_ISLOCKED(vp, curthread) && > - VOP_GETATTR(vp, &va, > - curthread->td_ucred, > - curthread)) { > + !VOP_GETATTR(vp, &va, > + curthread->td_ucred, > + curthread)) { > printf(" inode=%ld, fsid=%d, ftype=%d", > va.va_fileid, va.va_fsid, > vp->v_type); -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021010104941.jhb>