From owner-freebsd-fs@FreeBSD.ORG  Tue Oct  5 07:05:20 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92BE4106564A;
	Tue,  5 Oct 2010 07:05:20 +0000 (UTC)
	(envelope-from to.my.trociny@gmail.com)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com
	[209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id E79B88FC0A;
	Tue,  5 Oct 2010 07:05:19 +0000 (UTC)
Received: by mail-fx0-f54.google.com with SMTP id 9so4567035fxm.13
	for <multiple recipients>; Tue, 05 Oct 2010 00:05:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:subject
	:organization:references:date:in-reply-to:message-id:user-agent
	:mime-version:content-type;
	bh=UgQoTrG66aqcYQ29T4sKa9CWvFkQthVwd8H25HdbR1s=;
	b=RF4Bzz6cRI8kuUs6aqvShRqtpB1V8Q1Dr6GS/V7h2p1qq6u+xuRDYBR2Ly1Hv+J6zl
	wCeVMZPK8UE5KPLvHi76GsfktRyhZet2l6n7VKZRyCFY+v4tmUqt2FcSI6dWuR7xiFe7
	tAEQSCpobFqjoD9obCRoDiwZgU1Oxt+tDAWJQ=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:organization:references:date:in-reply-to
	:message-id:user-agent:mime-version:content-type;
	b=R1YbUlZwDCtWfsso1KiOAelMq4XZSc2HCyOC0nitp7nO1i2IMS9b2Hhdw3WUBS80SG
	h6RjOJ99ZA4a+vL6ix5mVAAFjIPKKY66O8+hAnuEhlsgRwa+RdLcgzLt6rTLO5fJu+vd
	gUPPSpzAnc98YTFqbnh2x9uFTI5Du/i2lncTs=
Received: by 10.223.126.15 with SMTP id a15mr10018089fas.67.1286262319649;
	Tue, 05 Oct 2010 00:05:19 -0700 (PDT)
Received: from localhost (ua1.etadirect.net [91.198.140.16])
	by mx.google.com with ESMTPS id 2sm2698431faz.38.2010.10.05.00.05.16
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Tue, 05 Oct 2010 00:05:16 -0700 (PDT)
From: Mikolaj Golub <to.my.trociny@gmail.com>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Organization: TOA Ukraine
References: <86hbh44wgl.fsf@kopusha.home.net> <86aamw4l42.fsf@kopusha.home.net>
	<20101004213647.GK7322@garage.freebsd.pl>
Date: Tue, 05 Oct 2010 10:05:13 +0300
In-Reply-To: <20101004213647.GK7322@garage.freebsd.pl> (Pawel Jakub Dawidek's
	message of "Mon, 4 Oct 2010 23:36:47 +0200")
Message-ID: <86tyl1m85y.fsf@zhuzha.ua1>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: freebsd-fs@freebsd.org
Subject: Re: hastd: assertion (res->hr_event != NULL) fails in secondary on
	split-brain
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2010 07:05:20 -0000


On Mon, 4 Oct 2010 23:36:47 +0200 Pawel Jakub Dawidek wrote:

 PJD> I see three problems:)

 PJD> 1. In child_kill() you interpret status value always, even if it is
 PJD>    invalid due to earlier errors.
 PJD> 2. While copying the code you changed style. Don't you like style(9)?:)

Me like :-). But it looks like my emacs don't. Need to teach it somehow...

 PJD> 3. The patch doesn't fix the root cause of the problem.

Thank you for your comments.

-- 
Mikolaj Golub