From owner-freebsd-net  Tue Nov  5 13:15:13 2002
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 63DA337B404
	for <freebsd-net@FreeBSD.ORG>; Tue,  5 Nov 2002 13:15:12 -0800 (PST)
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 52A3A43E75
	for <freebsd-net@FreeBSD.ORG>; Tue,  5 Nov 2002 13:15:11 -0800 (PST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id NAA36596;
	Tue, 5 Nov 2002 13:07:10 -0800 (PST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gA5L6lZE039809;
	Tue, 5 Nov 2002 13:06:47 -0800 (PST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gA5L6igd039808;
	Tue, 5 Nov 2002 13:06:44 -0800 (PST)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200211052106.gA5L6igd039808@arch20m.dellroad.org>
Subject: Re: NFS functions does *NOT* check if they really have allocated any
 memory
In-Reply-To: <20021105183154.I80368-100000@shadowhand.OTEL.net>
 "from Iasen Kostov at Nov 5, 2002 07:25:33 pm"
To: Iasen Kostov <ikostov@otel.net>
Date: Tue, 5 Nov 2002 13:06:44 -0800 (PST)
Cc: freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL88 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

Iasen Kostov writes:
>   As I experience system crushes at time of mbufs exhaustion I've compiled
> a debug kernel and traced the problem. I seems the NFS functions
> (nfsm_rpchead, nfsm_reqh ...) does *NOT* chek if they really have
> allocated memory by MGET macro.

No check is necessary if M_WAIT is specified; the M_GET() function
is always successful in that case. Same for malloc().

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message