From owner-p4-projects Thu Oct 10 8:23:35 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6C2F737B404; Thu, 10 Oct 2002 08:23:33 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB96F37B401; Thu, 10 Oct 2002 08:23:32 -0700 (PDT) Received: from sentry.gw.tislabs.com (sentry.gw.tislabs.com [192.94.214.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id C529843E91; Thu, 10 Oct 2002 08:23:31 -0700 (PDT) (envelope-from cvance@tislabs.com) Received: by sentry.gw.tislabs.com; id LAA23174; Thu, 10 Oct 2002 11:23:25 -0400 (EDT) Received: from zorg.gw.tislabs.com(10.33.60.104) by sentry.gw.tislabs.com via smap (V5.5) id xma023096; Thu, 10 Oct 02 15:22:24 GMT Received: from localhost (cvance@localhost) by zorg.gw.tislabs.com (8.11.2/8.11.2) with ESMTP id g9AFK7P17403; Thu, 10 Oct 2002 11:20:07 -0400 X-Authentication-Warning: zorg.gw.tislabs.com: cvance owned process doing -bs Date: Thu, 10 Oct 2002 11:20:07 -0400 (EDT) From: Chris Vance X-X-Sender: To: John Baldwin Cc: Chris Vance , Perforce Change Reviews Subject: RE: PERFORCE change 19023 for review In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 10 Oct 2002, John Baldwin wrote: > > On 10-Oct-2002 Chris Vance wrote: > > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > > > Fix bug. > > I don't know if the style below is some NAI thing, but if you were using > style(9), then the second lines would be at fixed offsets and wouldn't > have to change. This would result in a smaller, easier-to-read diff that > more obviously points out that you just added a single !. Just something > to think about. There are a lot of pratical things behind style(9). In case folks were curious, It's not a style thing so much as an issue with third-party code. I'm trying to maintain compatibility as close as possible to the upstream (SELinux) codebase. Obviously this particular chunk doesn't reduce _that_ diff, but it's the style for the surrounding code, so I've adopted it. chris. > > > Affected files ... > > > > .. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 edit > > > > Differences ... > > > > ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 (text+ko) ==== > > > > @@ -496,9 +496,9 @@ > > struct vnode *vp = a->u.fs.vp; > > struct vattr va; > > if (VOP_ISLOCKED(vp, curthread) && > > - VOP_GETATTR(vp, &va, > > - curthread->td_ucred, > > - curthread)) { > > + !VOP_GETATTR(vp, &va, > > + curthread->td_ucred, > > + curthread)) { > > printf(" inode=%ld, fsid=%d, ftype=%d", > > va.va_fileid, va.va_fsid, > > vp->v_type); > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message