Date: Thu, 10 Oct 2002 11:20:07 -0400 (EDT) From: Chris Vance <cvance@tislabs.com> To: John Baldwin <jhb@freebsd.org> Cc: Chris Vance <cvance@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 19023 for review Message-ID: <Pine.LNX.4.33.0210101117110.17166-100000@zorg.gw.tislabs.com> In-Reply-To: <XFMail.20021010104941.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 10 Oct 2002, John Baldwin wrote: > > On 10-Oct-2002 Chris Vance wrote: > > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > > > Fix bug. > > I don't know if the style below is some NAI thing, but if you were using > style(9), then the second lines would be at fixed offsets and wouldn't > have to change. This would result in a smaller, easier-to-read diff that > more obviously points out that you just added a single !. Just something > to think about. There are a lot of pratical things behind style(9). In case folks were curious, It's not a style thing so much as an issue with third-party code. I'm trying to maintain compatibility as close as possible to the upstream (SELinux) codebase. Obviously this particular chunk doesn't reduce _that_ diff, but it's the style for the surrounding code, so I've adopted it. chris. > > > Affected files ... > > > > .. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 edit > > > > Differences ... > > > > ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 (text+ko) ==== > > > > @@ -496,9 +496,9 @@ > > struct vnode *vp = a->u.fs.vp; > > struct vattr va; > > if (VOP_ISLOCKED(vp, curthread) && > > - VOP_GETATTR(vp, &va, > > - curthread->td_ucred, > > - curthread)) { > > + !VOP_GETATTR(vp, &va, > > + curthread->td_ucred, > > + curthread)) { > > printf(" inode=%ld, fsid=%d, ftype=%d", > > va.va_fileid, va.va_fsid, > > vp->v_type); > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.33.0210101117110.17166-100000>