From owner-svn-src-head@freebsd.org Sun Mar 1 22:10:53 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB6F325003E; Sun, 1 Mar 2020 22:10:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48VyCK2s9cz3MQF; Sun, 1 Mar 2020 22:10:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x841.google.com with SMTP id v22so2610818qtp.10; Sun, 01 Mar 2020 14:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tbIZi4rxEzwy1XLFVcv+DE+zH44CJZnzsWhr0vmRRn8=; b=p4icAgZBc1CN6wNPmQFO2E9nIK58lszTTBXdq/P8zbkBw/lQY1++/cK3ytJhR2n26K o7Sa0rdVq509Sion44sMa/50jvMyf89j63/gPGhNmYGGfyZFYClwmb6xqa7uDPZPfWIh XWB2Z15AutaUX46u0zTbh06F+IADKZFJ9JkQuxyYZr6l2sABUV62rhieFWZiAr3x/LpQ ZygwVafofhmhJ6qcg9PTkKapaNuTDd81XfIWWW+WGepRtkI8ALRL9NS9CQN99xJhtGNh vjwrAin+ZBh7tnEnASEMDYSFb0xVD4bZJ+7o0T+uBDbGnaBBc3yPeXBc1Uqv2qCBnKu7 kU1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=tbIZi4rxEzwy1XLFVcv+DE+zH44CJZnzsWhr0vmRRn8=; b=WrKqvlegnP8JHa4KPUPA4YGMuxoN2u/YCCYYPuwmwo6g1mDLQk/kALDBaoYAHXFF1j p+xt6gCNMBAJZ7rVKltzulvq6hzTqQSIfKxAWaQZt0Xko8ddCwfXJ1o+M4rzlSgm5W4L AvVVW+Kmk82tHR13oNyXMajUG4PkK2iFK6j9riOxgqk9m+ivTUiRLs0TXy6d4exMYjQy INuUbqIau+4vukehdu0XKxWkaWgwtWoAqYj3Mk/khniQcGMMJytAtvb5kdP8KDUgQc6+ BGicSgHj4ulVKgI/BXJaOOwWf/zzwqmBp8L6jx60R+b6aGKEtRADUhpSxT8MvUofOZPz 3N5Q== X-Gm-Message-State: APjAAAURplYmUqJ8j35pbkEPBsTzhiKhCQFMCEWPCmK7AbjnjJT53+lh M1TbnoyAjLMt/BZo2FxPGIWI5gRY X-Google-Smtp-Source: APXvYqw6r9hpb34D6sqJEP2GB12ZrodBUYrkxMDhgA6YjNDCtf10AY3AkFtTJC4hei9ZtRLvRTJGPA== X-Received: by 2002:ac8:1673:: with SMTP id x48mr13099523qtk.201.1583100652250; Sun, 01 Mar 2020 14:10:52 -0800 (PST) Received: from raichu (toroon0560w-lp130-11-70-50-21-248.dsl.bell.ca. [70.50.21.248]) by smtp.gmail.com with ESMTPSA id f12sm738616qkm.13.2020.03.01.14.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 14:10:51 -0800 (PST) Sender: Mark Johnston Date: Sun, 1 Mar 2020 17:10:49 -0500 From: Mark Johnston To: Jan Beich Cc: Emmanuel Vadot , Jeff Roberson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358363 - head/sys/vm Message-ID: <20200301221049.GB33873@raichu> References: <202002270237.01R2bRLJ023799@repo.freebsd.org> <20200229212411.1e6aed2d49d6644937b78452@bidouilliste.com> <20200301212537.GA33873@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48VyCK2s9cz3MQF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2020 22:10:53 -0000 On Sun, Mar 01, 2020 at 10:58:17PM +0100, Jan Beich wrote: > Mark Johnston writes: > > > On Sat, Feb 29, 2020 at 09:24:11PM +0100, Emmanuel Vadot wrote: > > > >> > >> Hi Jeff, > >> > >> On Thu, 27 Feb 2020 02:37:27 +0000 (UTC) > >> Jeff Roberson wrote: > >> > >> > Author: jeff > >> > Date: Thu Feb 27 02:37:27 2020 > >> > New Revision: 358363 > >> > URL: https://svnweb.freebsd.org/changeset/base/358363 > >> > > >> > Log: > >> > Add unlocked grab* function variants that use lockless radix code to > >> > lookup pages. These variants will fall back to their locked counterparts > >> > if the page is not present. > >> > > >> > Discussed with: kib, markj > >> > Differential Revision: https://reviews.freebsd.org/D23449 > >> > > >> > Modified: > >> > head/sys/vm/vm_page.c > >> > head/sys/vm/vm_page.h > >> > > >> > >> We're (jbeich@ and me) seeing wired memory leak since this commit. > >> A simple way to reproduce is to have drm-kmod (either 4.16 or 5.0) and > >> liba-intel-driver/libva-intel-media-driver and start mpv in a loop : > >> > >> while mpv --hwdec=vaapi --start=10.0 --end=10.1 /path/to/file ; do > >> done > >> > >> Reverting this commit on one of my test machine shows that this is the > >> culprit. > >> If you need anymore info/debug let me know. > >> > >> Thanks. > > > > Could you give this patch a try? > > > > diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c > > index 9d50881ed27e..41e7a5bb3099 100644 > > --- a/sys/vm/vm_page.c > > +++ b/sys/vm/vm_page.c > > @@ -4535,7 +4535,8 @@ vm_page_grab_valid(vm_page_t *mp, vm_object_t object, vm_pindex_t pindex, int al > > (VM_ALLOC_NOWAIT | VM_ALLOC_WAITFAIL | VM_ALLOC_ZERO)) == 0, > > ("vm_page_grab_valid: Invalid flags 0x%X", allocflags)); > > VM_OBJECT_ASSERT_WLOCKED(object); > > - pflags = allocflags & ~(VM_ALLOC_NOBUSY | VM_ALLOC_SBUSY); > > + pflags = allocflags & ~(VM_ALLOC_NOBUSY | VM_ALLOC_SBUSY | > > + VM_ALLOC_WIRED); > > pflags |= VM_ALLOC_WAITFAIL; > > > > retrylookup: > > I confirm, the patch fixes the issue. After trying to reproduce for a > few minutes Wired doesn't grow several times larger than ARC Total. Thanks, committed in r358505.