From owner-freebsd-arch@FreeBSD.ORG  Tue Mar 23 02:38:32 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAC84106566C;
	Tue, 23 Mar 2010 02:38:32 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 6AEF18FC1F;
	Tue, 23 Mar 2010 02:38:32 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o2N2Zq0w034669;
	Mon, 22 Mar 2010 20:35:52 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 22 Mar 2010 20:35:53 -0600 (MDT)
Message-Id: <20100322.203553.752311254955266835.imp@bsdimp.com>
To: jhb@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201003221605.24538.jhb@freebsd.org>
References: <20100322.125937.278730673160410010.imp@bsdimp.com>
	<20100322.130512.864843819464264610.imp@bsdimp.com>
	<201003221605.24538.jhb@freebsd.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Alexander@leidinger.net, rwatson@FreeBSD.org, freebsd-arch@FreeBSD.org
Subject: Re: CTF patch for testing/review
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2010 02:38:32 -0000

In message: <201003221605.24538.jhb@freebsd.org>
            John Baldwin <jhb@FreeBSD.org> writes:
: On Monday 22 March 2010 3:05:12 pm M. Warner Losh wrote:
: > In message: <20100322.125937.278730673160410010.imp@bsdimp.com>
: >             M. Warner Losh <imp@bsdimp.com> writes:
: > : In message: <20100322172104.14234yawbsev0sw8@webmail.leidinger.net>
: > :             Alexander Leidinger <Alexander@Leidinger.net> writes:
: > : : Normally we use MK_xxx for things which are opt-in/opt-out. What about
: > : : using MK_xxx instead of ENABLE_CTF? If people are in favour of MK_xxx,
: > : : what should the xxx part look like?
: > : 
: > : Normally we *TEST* MK_XXX for things which are opt-in/opt-out and
: > : require the user to say WITH_XXX or WITHOUT_XXX if they don't like the
: > : default (or want to ensure they get option XXX, even if we turn it off
: > : by default in the future).  The default then gets encoded in
: > : bsd.own.mk, and permeates the FreeBSD build system since we include
: > : that everywhere, directly or indirectly.
: > : 
: > : The problem is that bsd.own.mk is not included in sys.mk, nor should
: > : it be.  That's why we have the hacky combination of WITH_CTF and
: > : NO_CTF that's there today.
: > : 
: > : : Is bsd.kern.mk included in module builds too?
: > : 
: > : Yes.
: > 
: > One last thing I should have said was that the patch that was posted
: > earlier in the thread looked ok, and likely couldn't be made
: > significantly better due to the bsd.own.mk issue.
: 
: I think the patch is a good approach, I just think it needs to default to not 
: enabling CTF by default.  Instead, various bsd.foo.mk should selectively 
: enable it.

I should have added that bit as well...

Warner