From owner-svn-src-all@freebsd.org Wed May 9 20:29:07 2018 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE1CAFCB438 for <svn-src-all@mailman.ysv.freebsd.org>; Wed, 9 May 2018 20:29:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A4FE853D6 for <svn-src-all@freebsd.org>; Wed, 9 May 2018 20:29:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22a.google.com with SMTP id p3-v6so525123itc.0 for <svn-src-all@freebsd.org>; Wed, 09 May 2018 13:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QGfGg+vV8nzIcw/n+loR05qrF7nWZpdCg2GcMDdUYQ8=; b=1YkDSbV3dM9n8humA1I9pEjCAhf26GfnLRs0eAuvcr2OjTH0KQ+5O47Iq580hJnT0C yN1Q9bXW0YgD+qpeLrhPDcJubO5MoGNU77YMTRT/ww4d5hwmTpycbDVurCWXPeFxvtPi +jMwNnQ1LRrU2JiKMArewdCfGqbKBVUCTKGCBd9lIc7wOArXKLMA98z7vY0+Q2rQWunG gmg2uBZe503Seltl5hNvqZjkT6KuGqdGHhOjNvPsxQwy1jD/oy1phzuKitzbKHBwCMsB YG9bCiLzr+Fw9IX+fa6Uexpd6/uMTJllIBtgLcWK6B2JUnNA0YNBWmqf+o7ziMjmz/ka FW/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QGfGg+vV8nzIcw/n+loR05qrF7nWZpdCg2GcMDdUYQ8=; b=YKYEFLlDs+24p99vp7uDIY0Z61vSX5P/M9HtG368YahjvwiqWn4HBZSPYRwwpu1W2V DMIevfQ5CJYWs0Q8ihgBLg4OJVd1pg3NFZ3vg05ZirY+D/TerVghLwEzSaSwnKb5z0n5 NPvJAm7mjP/v/INwM/SrWtnmYpG5dhDf+m7j0UVwQ44IwpVZmW830EXN/oQgclfFdroh 090VbwaMrxpRPpB2uuvqQBURd/l3rCsq5bo8SCDSWmeu/Xhij0TA0GSg7aghxcj/1dbz J/RB47r418sya3UqBHRebMMr5C935B+ssgEkdeU0/keYKqA7PJ3tjZiBEXypx9pG4D32 gWoA== X-Gm-Message-State: ALKqPwcTHVKuOd3YnREkIxNscZXXotq5zcXYfm04tdI+cZld0sQZNZvk 4VuDPwC3i3Tn1AxKT9U+peJjl6HS0bODOIqlCCyX8A== X-Google-Smtp-Source: AB8JxZrK58hFtgihCHm4yszKqUqoO3mVaWfwO4ggrs3cxSYAByUS7zBMCphqkScnQfSB8zjSFhP8V4py8UR8dxQJdN8= X-Received: by 2002:a24:e983:: with SMTP id f125-v6mr11513240ith.36.1525897745730; Wed, 09 May 2018 13:29:05 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a649:0:0:0:0:0 with HTTP; Wed, 9 May 2018 13:29:05 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <1872360.cC9XDcqkuS@ralph.baldwin.cx> References: <201805090207.w49279t8006603@repo.freebsd.org> <4065288.o9QKfFzp22@ralph.baldwin.cx> <CANCZdfpYWQk0kWoBiPWX8UVgNTFWhFT7XKWWCv5HmeeGkmqSnw@mail.gmail.com> <1872360.cC9XDcqkuS@ralph.baldwin.cx> From: Warner Losh <imp@bsdimp.com> Date: Wed, 9 May 2018 14:29:05 -0600 X-Google-Sender-Auth: lKJsa5i1Ye6CuB8IYgHGXFqIrus Message-ID: <CANCZdfp=aAV3Ue+g9Yx64V_v7QP9_f8OuzA0OBv=vbBdc-dMeg@mail.gmail.com> Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet To: John Baldwin <jhb@freebsd.org> Cc: Cy Schubert <cy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 09 May 2018 20:29:07 -0000 On Wed, May 9, 2018 at 10:52 AM, John Baldwin <jhb@freebsd.org> wrote: > On Wednesday, May 09, 2018 10:02:06 AM Warner Losh wrote: > > On Wed, May 9, 2018 at 8:58 AM, John Baldwin <jhb@freebsd.org> wrote: > > > > > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote: > > > > Author: cy > > > > Date: Wed May 9 02:07:09 2018 > > > > New Revision: 333393 > > > > URL: https://svnweb.freebsd.org/changeset/base/333393 > > > > > > > > Log: > > > > Document intentional fallthrough. (CID 976535) > > > > > > > > MFC after: 1 week > > > > > > > > Modified: > > > > head/sys/contrib/ipfilter/netinet/fil.c > > > > > > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c > > > > ============================================================ > > > ================== > > > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 > 2018 > > > (r333392) > > > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 > 2018 > > > (r333393) > > > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin) > > > > } > > > > } > > > > #endif > > > > + /* fallthrough is intentional */ > > > > case ICMP_SOURCEQUENCH : > > > > case ICMP_REDIRECT : > > > > case ICMP_TIMXCEED : > > > > > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there > are > > > three other instances of that style in ipfilter already (and none > others > > > using this comment style). > > > > > > > /* FALLTHROUGH */ is actually an old-school lint directive that other > tools > > have picked up. > > Yes, but it is still the dominant style in the tree even if it has come > from > lint. > Agreed. I wasn't arguing, just saying it has a long history and everybody does it today even though lint's relevance has faded. Warner