From owner-p4-projects Thu Oct 10 8:47:46 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 90D5037B404; Thu, 10 Oct 2002 08:47:44 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26BF537B401; Thu, 10 Oct 2002 08:47:44 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id E64C643EA9; Thu, 10 Oct 2002 08:47:41 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id g9AFlCOo033159; Thu, 10 Oct 2002 11:47:13 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 10 Oct 2002 11:47:12 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Chris Vance Cc: John Baldwin , Chris Vance , Perforce Change Reviews Subject: RE: PERFORCE change 19023 for review In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 10 Oct 2002, Chris Vance wrote: > On Thu, 10 Oct 2002, John Baldwin wrote: > > > On 10-Oct-2002 Chris Vance wrote: > > > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > > > > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > > > > > Fix bug. > > > > I don't know if the style below is some NAI thing, but if you were using > > style(9), then the second lines would be at fixed offsets and wouldn't > > have to change. This would result in a smaller, easier-to-read diff that > > more obviously points out that you just added a single !. Just something > > to think about. There are a lot of pratical things behind style(9). > > In case folks were curious, It's not a style thing so much as an issue > with third-party code. I'm trying to maintain compatibility as close as > possible to the upstream (SELinux) codebase. Obviously this particular > chunk doesn't reduce _that_ diff, but it's the style for the surrounding > code, so I've adopted it. Yeah -- the usual exception to style rules is vendor code where long term synchronization and maintenance is an issue, and the diff reduction concern is relative to the vendor code rather than local code. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message