Date: Thu, 10 Oct 2002 11:47:12 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Chris Vance <cvance@tislabs.com> Cc: John Baldwin <jhb@freebsd.org>, Chris Vance <cvance@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 19023 for review Message-ID: <Pine.NEB.3.96L.1021010114625.33126B-100000@fledge.watson.org> In-Reply-To: <Pine.LNX.4.33.0210101117110.17166-100000@zorg.gw.tislabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 10 Oct 2002, Chris Vance wrote: > On Thu, 10 Oct 2002, John Baldwin wrote: > > > On 10-Oct-2002 Chris Vance wrote: > > > http://perforce.freebsd.org/p4db/chv.cgi?CH=19023 > > > > > > Change 19023 by cvance@cvance_laptop on 2002/10/10 07:14:36 > > > > > > Fix bug. > > > > I don't know if the style below is some NAI thing, but if you were using > > style(9), then the second lines would be at fixed offsets and wouldn't > > have to change. This would result in a smaller, easier-to-read diff that > > more obviously points out that you just added a single !. Just something > > to think about. There are a lot of pratical things behind style(9). > > In case folks were curious, It's not a style thing so much as an issue > with third-party code. I'm trying to maintain compatibility as close as > possible to the upstream (SELinux) codebase. Obviously this particular > chunk doesn't reduce _that_ diff, but it's the style for the surrounding > code, so I've adopted it. Yeah -- the usual exception to style rules is vendor code where long term synchronization and maintenance is an issue, and the diff reduction concern is relative to the vendor code rather than local code. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021010114625.33126B-100000>